Summary: Make builtin TypeErrors for |this| more consistent. There have been multiple ways to report errors for non-coeracble this objects. Approach 1: > if (this == null) { > if (this === null) > throw new @TypeError("X requires that |this| not be null"); > throw new @TypeError("X requires that |this| not be undefined"); > } Approach 2: > if (this === null) > throw new @TypeError("X requires that |this| not be null"); > > if (this === @undefined) > throw new @TypeError("X requires that |this| not be undefined"); Approach 3: > if (this == null) > throw new @TypeError("X requires that |this| not be null or undefined"); Of these approaches, the last is the simplest, the smallest (half the byte code size), and provides the most useful information (lists all the values |this| cannot be). Lets converge on this approach.
Created attachment 283930 [details] [PATCH] Proposed Fix
Comment on attachment 283930 [details] [PATCH] Proposed Fix r=me.
Comment on attachment 283930 [details] [PATCH] Proposed Fix Let me wait on cq+ until the bots run through it.
Comment on attachment 283930 [details] [PATCH] Proposed Fix Attachment 283930 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1703425 New failing tests: sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3.html
Created attachment 283938 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 283930 [details] [PATCH] Proposed Fix Attachment 283930 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1703408 New failing tests: sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3.html
Created attachment 283939 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 283930 [details] [PATCH] Proposed Fix Attachment 283930 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1703421 New failing tests: sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3.html
Created attachment 283940 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 283930 [details] [PATCH] Proposed Fix Attachment 283930 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1703381 New failing tests: sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3.html sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3.html
Created attachment 283941 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5
Created attachment 283959 [details] [PATCH] For Landing Rebaseline those results.
Comment on attachment 283959 [details] [PATCH] For Landing Clearing flags on attachment: 283959 Committed r203393: <http://trac.webkit.org/changeset/203393>