Bug 159898 - Clean up float styles for video and image placement
Summary: Clean up float styles for video and image placement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-18 13:57 PDT by Jon Davis
Modified: 2016-07-19 10:24 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.79 KB, patch)
2016-07-18 14:00 PDT, Jon Davis 		no flags Details | Formatted Diff | Diff
Patch (2.29 KB, patch)
2016-07-18 14:05 PDT, Jon Davis 		no flags Details | Formatted Diff | Diff
Patch (2.44 KB, patch)
2016-07-18 14:56 PDT, Jon Davis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2016-07-18 13:57:01 PDT 
Floating videos need sized to allow for readable text. Special margin treatments are needed for first-line floating elements.
Comment 1 Jon Davis 2016-07-18 14:00:56 PDT 
Created attachment 283929 [details]
Patch
Comment 2 Jon Davis 2016-07-18 14:05:46 PDT 
Created attachment 283931 [details]
Patch
Comment 3 Joseph Pecoraro 2016-07-18 14:11:43 PDT 
Comment on attachment 283931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283931&action=review

rs=me

> Websites/webkit.org/ChangeLog:11
> +        (@media only screen and (max-width: 415px)):

This seems to be a lie, you could update it to what it actually is, or just drop it.

> Websites/webkit.org/ChangeLog:12
> +        (#post-4132 pre:nth-child(-n+8)):

This is a lie, you can remove this line.
Comment 4 Jon Davis 2016-07-18 14:56:34 PDT 
Created attachment 283937 [details]
Patch
Comment 5 Benjamin Poulain 2016-07-18 17:53:33 PDT 
Comment on attachment 283937 [details]
Patch

lgtm
Comment 6 Jon Davis 2016-07-19 10:04:22 PDT 
Comment on attachment 283937 [details]
Patch

Thanks!
Comment 7 WebKit Commit Bot 2016-07-19 10:24:55 PDT 
Comment on attachment 283937 [details]
Patch

Clearing flags on attachment: 283937

Committed r203410: <http://trac.webkit.org/changeset/203410>
Comment 8 WebKit Commit Bot 2016-07-19 10:24:59 PDT 
All reviewed patches have been landed.  Closing bug.