Bug 159897 - EventTarget.dispatchEvent() parameter should not be nullable
Summary: EventTarget.dispatchEvent() parameter should not be nullable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#interfac...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-18 13:48 PDT by Chris Dumez
Modified: 2016-07-18 18:19 PDT (History)
9 users (show)

See Also:

Attachments
Patch (10.31 KB, patch)
2016-07-18 13:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (15.41 KB, patch)
2016-07-18 15:46 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-18 13:48:52 PDT 
EventTarget.dispatchEvent() parameter should not be nullable:
- https://dom.spec.whatwg.org/#interface-eventtarget

Even though the parameter is currently marked as nullable in our IDL, our implementation does a null check and we already throw a TypeError when calling dispatchEvent(null).
We should update the IDL so that it matches the specification and so that the null check is generated in the bindings instead.
Comment 1 Chris Dumez 2016-07-18 13:51:21 PDT 
Created attachment 283926 [details]
Patch
Comment 2 Chris Dumez 2016-07-18 15:46:43 PDT 
Created attachment 283947 [details]
Patch
Comment 3 WebKit Commit Bot 2016-07-18 18:19:01 PDT 
Comment on attachment 283947 [details]
Patch

Clearing flags on attachment: 283947

Committed r203391: <http://trac.webkit.org/changeset/203391>
Comment 4 WebKit Commit Bot 2016-07-18 18:19:06 PDT 
All reviewed patches have been landed.  Closing bug.