Bug 159867 - "make ARCHS=x86_64" fails to build
Summary: "make ARCHS=x86_64" fails to build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-17 22:47 PDT by Alexey Proskuryakov
Modified: 2016-08-20 08:02 PDT (History)
3 users (show)

See Also:

Attachments
proposed fix (1.16 KB, patch)
2016-07-17 22:50 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2016-07-17 22:47:01 PDT 
Makefile.shared sets ONLY_ACTIVE_ARCH=NO whenever ARCHS is set, and Plugin.32 cannot build when ARCHS=x86_64.

This is different from what happens for "set-wevbkit-configuration --64-bit; make". In the latter case, the makefile doesn't do special custom for architectures (unless OVERRIDE_ARCHS is set, which is only done in LayoutTestRelay/Makefile). So ONLY_ACTIVE_ARCH remains at YES, and xcconfig files do their magic to override VALID_ARCHS and have Plugin.32 build as 64-bit.
Comment 1 Alexey Proskuryakov 2016-07-17 22:50:11 PDT 
Created attachment 283885 [details]
proposed fix
Comment 2 WebKit Commit Bot 2016-07-18 09:18:45 PDT 
Comment on attachment 283885 [details]
proposed fix

Clearing flags on attachment: 283885

Committed r203348: <http://trac.webkit.org/changeset/203348>
Comment 3 WebKit Commit Bot 2016-07-18 09:18:49 PDT 
All reviewed patches have been landed.  Closing bug.