RESOLVED FIXED 159867
"make ARCHS=x86_64" fails to build 
https://bugs.webkit.org/show_bug.cgi?id=159867
Summary "make ARCHS=x86_64" fails to build
Alexey Proskuryakov
Reported 2016-07-17 22:47:01 PDT
Makefile.shared sets ONLY_ACTIVE_ARCH=NO whenever ARCHS is set, and Plugin.32 cannot build when ARCHS=x86_64. This is different from what happens for "set-wevbkit-configuration --64-bit; make". In the latter case, the makefile doesn't do special custom for architectures (unless OVERRIDE_ARCHS is set, which is only done in LayoutTestRelay/Makefile). So ONLY_ACTIVE_ARCH remains at YES, and xcconfig files do their magic to override VALID_ARCHS and have Plugin.32 build as 64-bit.
Attachments
proposed fix (1.16 KB, patch)
2016-07-17 22:50 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-07-17 22:50:11 PDT
Created attachment 283885 [details] proposed fix
WebKit Commit Bot
Comment 2 2016-07-18 09:18:45 PDT
Comment on attachment 283885 [details] proposed fix Clearing flags on attachment: 283885 Committed r203348: <http://trac.webkit.org/changeset/203348>
WebKit Commit Bot
Comment 3 2016-07-18 09:18:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.