Bug 159858 - DFG CSE is broken for MultiGetByOffset
Summary: DFG CSE is broken for MultiGetByOffset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 159859
  Show dependency tree / graph
 
Reported: 2016-07-16 15:37 PDT by Filip Pizlo
Modified: 2016-07-17 15:01 PDT (History)
5 users (show)

See Also:

Attachments
the patch (3.65 KB, patch)
2016-07-16 16:35 PDT, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
performance (79.20 KB, text/plain)
2016-07-16 16:35 PDT, Filip Pizlo 		no flags Details
patch for landing (3.58 KB, patch)
2016-07-17 12:09 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-07-16 15:37:01 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-07-16 16:35:17 PDT 
Created attachment 283854 [details]
the patch
Comment 2 Filip Pizlo 2016-07-16 16:35:58 PDT 
Created attachment 283855 [details]
performance

It's cheap to disable CSE for MultiGetByOffset, probably because B3 also does CSE and can handle the CFG constructs inside MultiGetByOffset.
Comment 3 Saam Barati 2016-07-16 22:17:36 PDT 
Comment on attachment 283854 [details]
the patch

r=me
Comment 4 Filip Pizlo 2016-07-17 12:09:28 PDT 
Created attachment 283870 [details]
patch for landing
Comment 5 Filip Pizlo 2016-07-17 15:01:53 PDT 
Landed in https://trac.webkit.org/changeset/203336