Bug 159854 - [JSC] Enable test262 module tests
Summary: [JSC] Enable test262 module tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-16 11:56 PDT by Yusuke Suzuki
Modified: 2016-07-17 07:40 PDT (History)
8 users (show)

See Also:

Attachments
Patch (103.76 KB, patch)
2016-07-16 12:06 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (104.01 KB, patch)
2016-07-16 12:20 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-07-16 11:56:19 PDT 
[JSC] Enable test262 module tests
Comment 1 Yusuke Suzuki 2016-07-16 12:06:52 PDT 
Created attachment 283849 [details]
Patch
Comment 2 Yusuke Suzuki 2016-07-16 12:20:26 PDT 
Created attachment 283850 [details]
Patch
Comment 3 Saam Barati 2016-07-16 15:08:42 PDT 
Comment on attachment 283850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283850&action=review

r=me

> Source/JavaScriptCore/jsc.cpp:2073
> +    auto checkException = [&](bool isLastFile, bool hasException, JSValue value) {

I think it's WebKit style to have a space between ] and (
but it may be worth double checking.
Comment 4 Yusuke Suzuki 2016-07-17 07:37:34 PDT 
Comment on attachment 283850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283850&action=review

Thanks!

>> Source/JavaScriptCore/jsc.cpp:2073
>> +    auto checkException = [&](bool isLastFile, bool hasException, JSValue value) {
> 
> I think it's WebKit style to have a space between ] and (
> but it may be worth double checking.

It seems that many lambdas are defined as `[&] (...) {`. So I'll follow that.
(Webkit code style guideline says nothing about lambdas. Maybe, it should be updated.)
Comment 5 Yusuke Suzuki 2016-07-17 07:40:08 PDT 
Committed r203332: <http://trac.webkit.org/changeset/203332>