WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
159847
Update SVGException to use the description in toString()
https://bugs.webkit.org/show_bug.cgi?id=159847
Summary
Update SVGException to use the description in toString()
Brady Eidson
Reported
2016-07-15 16:40:03 PDT
Update SVGException to use the description in toString() Part of
https://bugs.webkit.org/show_bug.cgi?id=159822
Attachments
Patch
(76.73 KB, patch)
2016-07-15 23:14 PDT
,
Brady Eidson
darin
: review+
Details
Formatted Diff
Diff
Patch for landing (with console.log change)
(76.71 KB, patch)
2016-07-16 13:05 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Patch for landing with console.log change
(76.94 KB, patch)
2016-07-16 13:09 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Brady Eidson
Comment 1
2016-07-15 23:14:26 PDT
Created
attachment 283844
[details]
Patch
Darin Adler
Comment 2
2016-07-16 08:46:47 PDT
Comment on
attachment 283844
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=283844&action=review
> LayoutTests/svg/filters/feBlend-invalid-mode-expected.txt:1 > +CONSOLE MESSAGE: line 14: An invalid value was passed to an operation or assigned to an attribute.: An invalid value was passed to an operation or assigned to an attribute.
This looks bad. Is this really a progression?
Brady Eidson
Comment 3
2016-07-16 09:59:03 PDT
(In reply to
comment #2
)
> Comment on
attachment 283844
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=283844&action=review
> > > LayoutTests/svg/filters/feBlend-invalid-mode-expected.txt:1 > > +CONSOLE MESSAGE: line 14: An invalid value was passed to an operation or assigned to an attribute.: An invalid value was passed to an operation or assigned to an attribute. > > This looks bad. Is this really a progression?
That's really weird. Will double check before landing.
Brady Eidson
Comment 4
2016-07-16 12:51:31 PDT
(In reply to
comment #3
)
> (In reply to
comment #2
) > > Comment on
attachment 283844
[details]
> > Patch > > > > View in context: > >
https://bugs.webkit.org/attachment.cgi?id=283844&action=review
> > > > > LayoutTests/svg/filters/feBlend-invalid-mode-expected.txt:1 > > > +CONSOLE MESSAGE: line 14: An invalid value was passed to an operation or assigned to an attribute.: An invalid value was passed to an operation or assigned to an attribute. > > > > This looks bad. Is this really a progression? > > That's really weird. Will double check before landing.
The reason for this is because of how the inspector reports exceptions in the console. I'll add a stop-gap utility method for now to provide a reasonable string. I filed
https://bugs.webkit.org/show_bug.cgi?id=159855
to track moving console messages over to "toString()" once we're all done with
bug 159822
Brady Eidson
Comment 5
2016-07-16 13:05:13 PDT
Created
attachment 283852
[details]
Patch for landing (with console.log change)
Brady Eidson
Comment 6
2016-07-16 13:05:27 PDT
Letting EWS run on the patch for landing, then I'll cq+
Brady Eidson
Comment 7
2016-07-16 13:06:23 PDT
Whoops, bad changelog here, just a sec.
Brady Eidson
Comment 8
2016-07-16 13:09:55 PDT
Created
attachment 283853
[details]
Patch for landing with console.log change
WebKit Commit Bot
Comment 9
2016-07-16 14:33:53 PDT
Comment on
attachment 283853
[details]
Patch for landing with console.log change Clearing flags on attachment: 283853 Committed
r203328
: <
http://trac.webkit.org/changeset/203328
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug