Bug 159847 - Update SVGException to use the description in toString()
Summary: Update SVGException to use the description in toString()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 159822
  Show dependency treegraph
 
Reported: 2016-07-15 16:40 PDT by Brady Eidson
Modified: 2016-07-16 15:28 PDT (History)
2 users (show)

See Also:


Attachments
Patch (76.73 KB, patch)
2016-07-15 23:14 PDT, Brady Eidson
darin: review+
Details | Formatted Diff | Diff
Patch for landing (with console.log change) (76.71 KB, patch)
2016-07-16 13:05 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch for landing with console.log change (76.94 KB, patch)
2016-07-16 13:09 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-07-15 16:40:03 PDT
Update SVGException to use the description in toString()

Part of https://bugs.webkit.org/show_bug.cgi?id=159822
Comment 1 Brady Eidson 2016-07-15 23:14:26 PDT
Created attachment 283844 [details]
Patch
Comment 2 Darin Adler 2016-07-16 08:46:47 PDT
Comment on attachment 283844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283844&action=review

> LayoutTests/svg/filters/feBlend-invalid-mode-expected.txt:1
> +CONSOLE MESSAGE: line 14: An invalid value was passed to an operation or assigned to an attribute.: An invalid value was passed to an operation or assigned to an attribute.

This looks bad. Is this really a progression?
Comment 3 Brady Eidson 2016-07-16 09:59:03 PDT
(In reply to comment #2)
> Comment on attachment 283844 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=283844&action=review
> 
> > LayoutTests/svg/filters/feBlend-invalid-mode-expected.txt:1
> > +CONSOLE MESSAGE: line 14: An invalid value was passed to an operation or assigned to an attribute.: An invalid value was passed to an operation or assigned to an attribute.
> 
> This looks bad. Is this really a progression?

That's really weird. Will double check before landing.
Comment 4 Brady Eidson 2016-07-16 12:51:31 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 283844 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=283844&action=review
> > 
> > > LayoutTests/svg/filters/feBlend-invalid-mode-expected.txt:1
> > > +CONSOLE MESSAGE: line 14: An invalid value was passed to an operation or assigned to an attribute.: An invalid value was passed to an operation or assigned to an attribute.
> > 
> > This looks bad. Is this really a progression?
> 
> That's really weird. Will double check before landing.

The reason for this is because of how the inspector reports exceptions in the console.

I'll add a stop-gap utility method for now to provide a reasonable string.

I filed https://bugs.webkit.org/show_bug.cgi?id=159855 to track moving console messages over to "toString()" once we're all done with bug 159822
Comment 5 Brady Eidson 2016-07-16 13:05:13 PDT
Created attachment 283852 [details]
Patch for landing (with console.log change)
Comment 6 Brady Eidson 2016-07-16 13:05:27 PDT
Letting EWS run on the patch for landing, then I'll cq+
Comment 7 Brady Eidson 2016-07-16 13:06:23 PDT
Whoops, bad changelog here, just a sec.
Comment 8 Brady Eidson 2016-07-16 13:09:55 PDT
Created attachment 283853 [details]
Patch for landing with console.log change
Comment 9 WebKit Commit Bot 2016-07-16 14:33:53 PDT
Comment on attachment 283853 [details]
Patch for landing with console.log change

Clearing flags on attachment: 283853

Committed r203328: <http://trac.webkit.org/changeset/203328>