Bug 159843 - Mac UI process needs to know about element focus and blur, much like iOS
Summary: Mac UI process needs to know about element focus and blur, much like iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-15 16:08 PDT by Beth Dakin
Modified: 2016-07-15 17:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (21.66 KB, patch)
2016-07-15 16:31 PDT, Beth Dakin 		no flags Details | Formatted Diff | Diff
Patch (21.61 KB, patch)
2016-07-15 16:33 PDT, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
Patch (21.95 KB, patch)
2016-07-15 16:56 PDT, Beth Dakin 		no flags Details | Formatted Diff | Diff
Patch for EWS (21.77 KB, patch)
2016-07-15 17:05 PDT, Beth Dakin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2016-07-15 16:08:10 PDT 
Mac UI process needs to know about element focus and blur, much like iOS

rdar://problem/27229504
Comment 1 Beth Dakin 2016-07-15 16:31:10 PDT 
Created attachment 283810 [details]
Patch
Comment 2 WebKit Commit Bot 2016-07-15 16:32:26 PDT 
Attachment 283810 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h:275:  The parameter name "editableElementIsFocused" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1423:  The parameter name "editableElementIsFocused" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2016-07-15 16:33:49 PDT 
Created attachment 283812 [details]
Patch
Comment 4 Tim Horton 2016-07-15 16:41:50 PDT 
Comment on attachment 283812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283812&action=review

> Source/WebKit2/UIProcess/mac/PageClientImpl.h:174
> +#if PLATFORM(MAC)

This file is already platform(mac)!

> Source/WebKit2/UIProcess/mac/PageClientImpl.mm:624
> +#if PLATFORM(MAC)

Ditto!
Comment 5 Beth Dakin 2016-07-15 16:56:12 PDT 
Created attachment 283815 [details]
Patch
Comment 6 Beth Dakin 2016-07-15 17:05:04 PDT 
Created attachment 283819 [details]
Patch for EWS
Comment 7 Beth Dakin 2016-07-15 17:41:05 PDT 
https://trac.webkit.org/changeset/203312