Bug 159841 – CSP: Improve support for multiple policies to more closely conform to the CSP Level 2 spec.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

Towards making our CSP multiple policies machinery more closely conform to section Enforcing multiple policies of the Content Security Policy Level 2 spec., <https://w3c.github.io/webappsec-csp/2/> (Editor's Draft, 25 April 2016), implement support for sending multiple CSP violation reports.

[Radar WebKit Bug Importer]

<rdar://problem/27381684>

[Daniel Bates]

Created attachment 283804 [details]
Patch and Layout Tests

[WebKit Commit Bot]

Attachment 283804 [details] did not pass style-queue:


ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:319:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:332:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:372:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:396:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:411:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:429:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:442:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:457:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:475:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:490:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:506:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:521:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:536:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:551:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:566:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:581:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:596:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:611:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.h:179:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 19 in 61 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Comment on attachment 283804 [details]
Patch and Layout Tests

View in context: https://bugs.webkit.org/attachment.cgi?id=283804&action=review

r=me

> Source/WebCore/page/csp/ContentSecurityPolicy.cpp:310
> +            return { true, true };

This could be a 'break' instead ...

[Daniel Bates]

Comment on attachment 283804 [details]
Patch and Layout Tests

View in context: https://bugs.webkit.org/attachment.cgi?id=283804&action=review

>> Source/WebCore/page/csp/ContentSecurityPolicy.cpp:310
>> +            return { true, true };
> 
> This could be a 'break' instead ...

Will change.

[Daniel Bates]

Committed r203434: <http://trac.webkit.org/changeset/203434>