Bug 159838 - Use fastHasAttribute() when possible
Summary: Use fastHasAttribute() when possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-15 15:04 PDT by Chris Dumez
Modified: 2016-07-16 10:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.08 KB, patch)
2016-07-15 15:06 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.35 KB, patch)
2016-07-15 15:17 PDT, Chris Dumez
rniwa: review+
rniwa: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-15 15:04:49 PDT
Use fastHasAttribute() when possible, for performance.
Comment 1 Chris Dumez 2016-07-15 15:06:39 PDT
Created attachment 283798 [details]
Patch
Comment 2 Chris Dumez 2016-07-15 15:17:37 PDT
Created attachment 283802 [details]
Patch
Comment 3 Ryosuke Niwa 2016-07-15 21:28:09 PDT
Comment on attachment 283802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283802&action=review

> Source/WebCore/ChangeLog:7
> +i

What's up with i here?
Comment 4 Chris Dumez 2016-07-15 23:11:12 PDT
Comment on attachment 283802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283802&action=review

>> Source/WebCore/ChangeLog:7
>> +i
> 
> What's up with i here?

Oh, gotta love vim :)
Comment 5 Chris Dumez 2016-07-16 10:22:01 PDT
Committed r203326: <http://trac.webkit.org/changeset/203326>