Bug 159825 - ScrollView::setHasHorizontalScrollbar / setHasVerticalScrollbar duplicate their logic
Summary: ScrollView::setHasHorizontalScrollbar / setHasVerticalScrollbar duplicate the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-15 12:29 PDT by Antonio Gomes
Modified: 2016-07-15 13:21 PDT (History)
1 user (show)

See Also:


Attachments
patch v1 (5.91 KB, patch)
2016-07-15 12:34 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
Patch (5.05 KB, patch)
2016-07-15 12:37 PDT, Antonio Gomes
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2016-07-15 12:29:17 PDT
I believe we can introduce a method to avoid this. Patch coming..
Comment 1 Antonio Gomes 2016-07-15 12:34:33 PDT
Created attachment 283782 [details]
patch v1
Comment 2 Antonio Gomes 2016-07-15 12:37:08 PDT
Created attachment 283783 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-07-15 13:06:31 PDT
Comment on attachment 283783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283783&action=review

> Source/WebCore/platform/ScrollView.cpp:121
> +

Extra blank line here.
Comment 4 Antonio Gomes 2016-07-15 13:20:45 PDT
(In reply to comment #3)
> Comment on attachment 283783 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=283783&action=review
> 
> > Source/WebCore/platform/ScrollView.cpp:121
> > +
> 
> Extra blank line here.

Done.
Comment 5 Antonio Gomes 2016-07-15 13:21:12 PDT
Committed r203294: <https://trac.webkit.org/r203294>.