Bug 159812 – [MSE][Mac] Pass AVSampleBufferDisplayLayer HDCP status to a newly created key session

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

[MSE][Mac] Pass AVSampleBufferDisplayLayer HDCP status to a newly created key session

[Radar WebKit Bug Importer]

<rdar://problem/27371624>

[Eric Carlson]

Created attachment 283759 [details]
Proposed patch.

[Jon Lee]

Comment on attachment 283759 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=283759&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:956
> +                weakThis->m_session->layerDidReceiveError(nullptr, weakThis->m_hdcpError.get(), ignored);

Should the error be cleared at this point?

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:1008
> +        m_hdcpError = error;

Should this be cleared if the code is not 'HDCP'? Are there other places where the error should be cleared?

[Eric Carlson]

Comment on attachment 283759 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=283759&action=review

>> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:956
>> +                weakThis->m_session->layerDidReceiveError(nullptr, weakThis->m_hdcpError.get(), ignored);
> 
> Should the error be cleared at this point?

I don't think it should, this method may be called again.

>> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:1008
>> +        m_hdcpError = error;
> 
> Should this be cleared if the code is not 'HDCP'? Are there other places where the error should be cleared?

It isn't currently possible to recover from an 'HDCP' error, so I don't think it should ever be cleared.

[WebKit Commit Bot]

Comment on attachment 283759 [details]
Proposed patch.

Clearing flags on attachment: 283759

Committed r203362: <http://trac.webkit.org/changeset/203362>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.