Bug 159812 - [MSE][Mac] Pass AVSampleBufferDisplayLayer HDCP status to a newly created key session
Summary: [MSE][Mac] Pass AVSampleBufferDisplayLayer HDCP status to a newly created key...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-15 06:47 PDT by Eric Carlson
Modified: 2016-07-18 12:19 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch. (3.22 KB, patch)
2016-07-15 06:59 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-07-15 06:47:09 PDT 
[MSE][Mac] Pass AVSampleBufferDisplayLayer HDCP status to a newly created key session
Comment 1 Radar WebKit Bug Importer 2016-07-15 06:50:43 PDT 
<rdar://problem/27371624>
Comment 2 Eric Carlson 2016-07-15 06:59:57 PDT 
Created attachment 283759 [details]
Proposed patch.
Comment 3 Jon Lee 2016-07-15 09:47:39 PDT 
Comment on attachment 283759 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=283759&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:956
> +                weakThis->m_session->layerDidReceiveError(nullptr, weakThis->m_hdcpError.get(), ignored);

Should the error be cleared at this point?

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:1008
> +        m_hdcpError = error;

Should this be cleared if the code is not 'HDCP'? Are there other places where the error should be cleared?
Comment 4 Eric Carlson 2016-07-15 10:07:18 PDT 
Comment on attachment 283759 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=283759&action=review

>> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:956
>> +                weakThis->m_session->layerDidReceiveError(nullptr, weakThis->m_hdcpError.get(), ignored);
> 
> Should the error be cleared at this point?

I don't think it should, this method may be called again.

>> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:1008
>> +        m_hdcpError = error;
> 
> Should this be cleared if the code is not 'HDCP'? Are there other places where the error should be cleared?

It isn't currently possible to recover from an 'HDCP' error, so I don't think it should ever be cleared.
Comment 5 WebKit Commit Bot 2016-07-18 12:19:18 PDT 
Comment on attachment 283759 [details]
Proposed patch.

Clearing flags on attachment: 283759

Committed r203362: <http://trac.webkit.org/changeset/203362>
Comment 6 WebKit Commit Bot 2016-07-18 12:19:21 PDT 
All reviewed patches have been landed.  Closing bug.