Bug 159811 – Fix expectedFailErrorHandler in run-jsc-stress-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

Tools/Scripts/run-jsc-stress-tests
-----------------------------------
# Error handler for tests that fail exactly when they return zero exit status.
def expectedFailErrorHandler
    Proc.new {
        | outp, plan |
        outp.puts "if test -e #{plan.failFile}"
        outp.puts "then"
        outp.puts "    " + plan.successCommand
        outp.puts "else"
        outp.puts "    (echo ERROR: Unexpected exit code: `cat #{plan.failFile}`) | " + redirectAndPrefixCommand(plan.name)
        outp.puts "    " + plan.failCommand
        outp.puts "fi"
    }
end


When a test expected to have a non zero exit code, it uses expectedFailErrorHandler function.
But its else case is buggy: plan.failFile doesn't exist in the else case, cat command fails now.

(note: discovered during running test262 tests and preparing patch to bug159810)

[Csaba Osztrogonác]

Created attachment 283757 [details]
Patch

[Csaba Osztrogonác]

ping?

[Csaba Osztrogonác]

Ping?

[Yusuke Suzuki]

Comment on attachment 283757 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 283757 [details]
Patch

Clearing flags on attachment: 283757

Committed r203448: <http://trac.webkit.org/changeset/203448>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.