Bug 159808 - Use a private property to implement FetchResponse.body getter
Summary: Use a private property to implement FetchResponse.body getter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on: 159921
Blocks: 151937 159804
  Show dependency treegraph
 
Reported: 2016-07-15 05:32 PDT by youenn fablet
Modified: 2016-07-22 23:02 PDT (History)
4 users (show)

See Also:


Attachments
Patch (15.42 KB, patch)
2016-07-15 07:16 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Retrying same patch as it works locally (15.42 KB, patch)
2016-07-15 08:36 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Retrying same patch as it works locally (15.44 KB, patch)
2016-07-18 02:16 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (20.73 KB, patch)
2016-07-19 08:10 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Rebasing (15.59 KB, patch)
2016-07-22 01:47 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-07-15 05:32:45 PDT
Currently, CachedAttribute is used.
Using a private property will allow direct use of this property from JS built-ins which will allow easier handling of ReadableStream cloning in Response.clone.
Also, this may allow removing some binding custom code.
Comment 1 youenn fablet 2016-07-15 07:16:12 PDT
Created attachment 283760 [details]
Patch
Comment 2 youenn fablet 2016-07-15 08:36:11 PDT
Created attachment 283762 [details]
Retrying same patch as it works locally
Comment 3 youenn fablet 2016-07-18 02:16:05 PDT
Created attachment 283894 [details]
Retrying same patch as it works locally
Comment 4 youenn fablet 2016-07-19 08:10:51 PDT
Created attachment 284005 [details]
Patch
Comment 5 WebKit Commit Bot 2016-07-19 08:13:32 PDT
Attachment 284005 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:82:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:83:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator'  [pylint/E0602] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alex Christensen 2016-07-19 10:14:52 PDT
Comment on attachment 284005 [details]
Patch

This looks reasonable to me.  Should it be r?, or are we waiting on https://bugs.webkit.org/show_bug.cgi?id=159921 ?
Comment 7 youenn fablet 2016-07-19 10:17:22 PDT
(In reply to comment #6)
> Comment on attachment 284005 [details]
> Patch
> 
> This looks reasonable to me.  Should it be r?, or are we waiting on
> https://bugs.webkit.org/show_bug.cgi?id=159921 ?

I would prefer to wait for bug 159921 so that this patch is solely focused on FetchResponse.
Comment 8 youenn fablet 2016-07-22 01:47:30 PDT
Created attachment 284316 [details]
Rebasing
Comment 9 WebKit Commit Bot 2016-07-22 23:02:22 PDT
Comment on attachment 284316 [details]
Rebasing

Clearing flags on attachment: 284316

Committed r203632: <http://trac.webkit.org/changeset/203632>
Comment 10 WebKit Commit Bot 2016-07-22 23:02:36 PDT
All reviewed patches have been landed.  Closing bug.