Bug 159803 – [GTK] Add basic tabs support to MiniBrowser

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Garcia Campos]

It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser. See bug #159512 for an example.

[Carlos Garcia Campos]

Created attachment 283750 [details]
Patch

[WebKit Commit Bot]

Attachment 283750 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/gtk/BrowserTab.c:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/gtk/BrowserTab.c:29:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/gtk/BrowserTab.c:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Tools/MiniBrowser/gtk/BrowserTab.c:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 4 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sergio Villar Senin]

Comment on attachment 283750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283750&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:768
> +    browserWindowUpdateZoomActions(window);

A bit unfortunate having to trigger all these events manually.

[Carlos Garcia Campos]

Committed r203271: <http://trac.webkit.org/changeset/203271>