Bug 159803 - [GTK] Add basic tabs support to MiniBrowser
Summary: [GTK] Add basic tabs support to MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-07-15 01:44 PDT by Carlos Garcia Campos
Modified: 2016-07-15 02:26 PDT (History)
3 users (show)

See Also:


Attachments
Patch (80.86 KB, patch)
2016-07-15 01:47 PDT, Carlos Garcia Campos
svillar: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-07-15 01:44:30 PDT
It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser. See bug #159512 for an example.
Comment 1 Carlos Garcia Campos 2016-07-15 01:47:17 PDT
Created attachment 283750 [details]
Patch
Comment 2 WebKit Commit Bot 2016-07-15 01:49:52 PDT
Attachment 283750 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/gtk/BrowserTab.c:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/gtk/BrowserTab.c:29:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/gtk/BrowserTab.c:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Tools/MiniBrowser/gtk/BrowserTab.c:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 4 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sergio Villar Senin 2016-07-15 02:21:12 PDT
Comment on attachment 283750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283750&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:768
> +    browserWindowUpdateZoomActions(window);

A bit unfortunate having to trigger all these events manually.
Comment 4 Carlos Garcia Campos 2016-07-15 02:26:14 PDT
Committed r203271: <http://trac.webkit.org/changeset/203271>