Bug 159797 - Return the correct value from Heap::externalMemorySize
Summary: Return the correct value from Heap::externalMemorySize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-14 17:30 PDT by Joseph Pecoraro
Modified: 2016-07-14 22:00 PDT (History)
13 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.50 KB, patch)
2016-07-14 17:34 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-07-14 17:30:41 PDT 
Return the correct value from Heap::externalMemorySize.

In practice this wasn't noticed because:

  m_externalMemorySize < m_extraMemorySize < Heap::extraMemorySize()
                                                ^ extra, deprecatedExtra, and ArrayBuffers

And the difference between m_externalMemorySize and m_extraMemorySize is relatively small. So this didn't cause any issues in the ResourceUsageOverlay / Web Inspector Memory Timeline. Still, we should use the correct value!
Comment 1 Radar WebKit Bug Importer 2016-07-14 17:31:23 PDT 
<rdar://problem/27362446>
Comment 2 Joseph Pecoraro 2016-07-14 17:34:02 PDT 
Created attachment 283716 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2016-07-14 21:59:57 PDT 
Comment on attachment 283716 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 283716

Committed r203268: <http://trac.webkit.org/changeset/203268>
Comment 4 WebKit Commit Bot 2016-07-14 22:00:02 PDT 
All reviewed patches have been landed.  Closing bug.