Bug 159796 - Move MediaSampleAVFObjC into its own file
Summary: Move MediaSampleAVFObjC into its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Enhancement
Assignee: George Ruan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-14 17:30 PDT by George Ruan
Modified: 2016-07-18 12:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (23.19 KB, patch)
2016-07-14 17:56 PDT, George Ruan 		no flags Details | Formatted Diff | Diff
Patch (23.13 KB, patch)
2016-07-15 09:49 PDT, George Ruan 		no flags Details | Formatted Diff | Diff
Patch (23.13 KB, patch)
2016-07-18 09:33 PDT, George Ruan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George Ruan 2016-07-14 17:30:17 PDT 
In preparation for a feature that uses MediaSampleAVFObjC, but does not need SourceBufferPrivateAVFObjC.
Comment 1 Radar WebKit Bug Importer 2016-07-14 17:33:21 PDT 
<rdar://problem/27362488>
Comment 2 George Ruan 2016-07-14 17:56:07 PDT 
Created attachment 283720 [details]
Patch
Comment 3 Eric Carlson 2016-07-14 22:18:30 PDT 
Comment on attachment 283720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283720&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaSampleAVFObjC.h:26
> +#ifndef MediaSampleAVFObjC_h

Not: this should use "#pragma once" instead
Comment 4 Eric Carlson 2016-07-14 22:19:44 PDT 
Comment on attachment 283720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283720&action=review

>> Source/WebCore/platform/graphics/avfoundation/MediaSampleAVFObjC.h:26
>> +#ifndef MediaSampleAVFObjC_h
> 
> Not: this should use "#pragma once" instead

Nit, not Not
Comment 5 George Ruan 2016-07-15 09:49:42 PDT 
Created attachment 283767 [details]
Patch
Comment 6 George Ruan 2016-07-18 09:33:44 PDT 
Created attachment 283910 [details]
Patch
Comment 7 WebKit Commit Bot 2016-07-18 12:24:36 PDT 
Comment on attachment 283910 [details]
Patch

Clearing flags on attachment: 283910

Committed r203363: <http://trac.webkit.org/changeset/203363>
Comment 8 WebKit Commit Bot 2016-07-18 12:24:39 PDT 
All reviewed patches have been landed.  Closing bug.