Bug 159793 - Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
Summary: Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-14 16:05 PDT by Chris Dumez
Modified: 2016-07-15 15:31 PDT (History)
7 users (show)

See Also:


Attachments
Patch (93.04 KB, patch)
2016-07-14 16:36 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (91.42 KB, patch)
2016-07-15 14:13 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-14 16:05:19 PDT
Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
Comment 1 Chris Dumez 2016-07-14 16:28:37 PDT
P.S: We should really rename fastGetAttribute() to getAttributeWithoutSynchronization() at some point.
Comment 2 Chris Dumez 2016-07-14 16:36:13 PDT
Created attachment 283707 [details]
Patch
Comment 3 WebKit Commit Bot 2016-07-15 14:11:09 PDT
Comment on attachment 283707 [details]
Patch

Rejecting attachment 283707 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 283707, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ching file Source/WebKit/win/DOMHTMLClasses.cpp
patching file Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm
patching file Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm
patching file Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm
patching file Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1687515
Comment 4 Chris Dumez 2016-07-15 14:13:46 PDT
Created attachment 283790 [details]
Patch
Comment 5 WebKit Commit Bot 2016-07-15 14:36:31 PDT
Comment on attachment 283790 [details]
Patch

Clearing flags on attachment: 283790

Committed r203302: <http://trac.webkit.org/changeset/203302>
Comment 6 WebKit Commit Bot 2016-07-15 14:36:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Adler 2016-07-15 15:31:18 PDT
(In reply to comment #1)
> P.S: We should really rename fastGetAttribute() to
> getAttributeWithoutSynchronization() at some point.

Or maybe attributeWithoutSynchronization.