Bug 159792 - Use more Refs with WorkQueues
Summary: Use more Refs with WorkQueues
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-14 15:59 PDT by Alex Christensen
Modified: 2016-07-14 17:12 PDT (History)
3 users (show)

See Also:

Attachments
Patch (15.43 KB, patch)
2016-07-14 15:59 PDT, Alex Christensen 		beidson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (541.83 KB, application/zip)
2016-07-14 16:23 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (385.02 KB, application/zip)
2016-07-14 16:29 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-07-14 15:59:00 PDT 
Use more Refs with WorkQueues
Comment 1 Alex Christensen 2016-07-14 15:59:17 PDT 
Created attachment 283698 [details]
Patch
Comment 2 Alex Christensen 2016-07-14 16:05:30 PDT 
https://trac.webkit.org/changeset/203248
Comment 3 Ryan Haddad 2016-07-14 16:22:24 PDT 
Reverted r203248 for reason:

This change causes LayoutTests to crash and exit early

Committed r203251: <http://trac.webkit.org/changeset/203251>
Comment 5 Build Bot 2016-07-14 16:23:08 PDT 
Comment on attachment 283698 [details]
Patch

Attachment 283698 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1682437

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2016-07-14 16:23:11 PDT 
Created attachment 283699 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-07-14 16:29:45 PDT 
Comment on attachment 283698 [details]
Patch

Attachment 283698 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1682451

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2016-07-14 16:29:47 PDT 
Created attachment 283704 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5
Comment 9 Ryan Haddad 2016-07-14 16:38:42 PDT 
On WK1, 200+ API tests failed with this change:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/builds/7862
Comment 10 Alex Christensen 2016-07-14 17:12:08 PDT 
HashMap<something, std::pair<Ref<something>, something>> causes awful problems like this right now.