Bug 15979 – Console logs in a database callback lose line number information

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Brady Eidson]

See http://bugs.webkit.org/show_bug.cgi?id=15976 and the layout test in LayoutTests/storage/transaction_callback_exception_crash.html

When an exception is thrown from within a callback, there is no line number information in the console log.

Why not?

[Oliver Hunt]

Okay, I have looked at this.  You don't get line/source information as you are throwing a primitive value which we cannot attach useful information to -- if you were to throw an object, everything should just work.

If that is the case then this is a duplicate of bug #18855

[Oliver Hunt]

I am now actually working on this.  There was a wide spread of incorrect exception handling (in the sense that value conversion was bogus, and line numbers being lost).

[Oliver Hunt]

Created attachment 22387 [details]
Fix exception handling in the many places it wasn't correct.

[Alexey Proskuryakov]

See also: bug 17470, bug 18232, bug 18234.

[Oliver Hunt]

Comment on attachment 22387 [details]
Fix exception handling in the many places it wasn't correct.

Mark reviewed, and requested a few changes. 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt
	A	LayoutTests/fast/js/exceptions-thrown-in-callbacks-expected.txt
	A	LayoutTests/fast/js/exceptions-thrown-in-callbacks.html
	M	LayoutTests/fast/xpath/nsresolver-exception-expected.txt
	M	LayoutTests/fast/xsl/transform-xhr-doc-expected.txt
	M	LayoutTests/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt
	M	LayoutTests/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt
	M	LayoutTests/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt
	M	LayoutTests/platform/mac/fast/dynamic/015-expected.txt
	M	LayoutTests/platform/mac/fast/events/updateLayoutForHitTest-expected.txt
	M	LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt
	M	LayoutTests/platform/mac/tables/mozilla_expected_failures/dom/appendCells1-expected.txt
	M	LayoutTests/platform/mac/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt
	M	LayoutTests/platform/mac/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt
	M	LayoutTests/platform/mac/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt
	M	LayoutTests/storage/transaction_callback_exception_crash-expected.txt
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/JSCustomSQLStatementCallback.cpp
	M	WebCore/bindings/js/JSCustomSQLStatementErrorCallback.cpp
	M	WebCore/bindings/js/JSCustomSQLTransactionCallback.cpp
	M	WebCore/bindings/js/JSCustomSQLTransactionErrorCallback.cpp
	M	WebCore/bindings/js/JSCustomVoidCallback.cpp
	M	WebCore/bindings/js/JSCustomXPathNSResolver.cpp
	M	WebCore/bindings/js/JSEventListener.cpp
	M	WebCore/bindings/js/ScheduledAction.cpp
	M	WebCore/bindings/js/ScriptController.cpp
	M	WebCore/bindings/objc/WebScriptObject.mm
	M	WebCore/page/Console.cpp
	M	WebCore/page/Console.h
Committed r35253