Bug 159778 – Web Inspector: Maintain selected function when switching between different profile representations

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Maintain selected function when switching between different profile representations.

Steps to Reproduce:
1. Inspect a page
2. Record a Timeline Profile with Scripts
3. Show Profile View
4. Select a function with Self Time
5. Toggle Inverted
  => Expected function to still be selected
6. Change Timeline Range selection slightly
  => Expected selection to stay the same

Notes:
- New up will be remembering expanded states, but remembering selection is a good first step.

[Radar WebKit Bug Importer]

<rdar://problem/27355913>

[Joseph Pecoraro]

Created attachment 283671 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 283671 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=283671&action=review

> Source/WebInspectorUI/UserInterface/Models/CallingContextTree.js:171
>  WebInspector.CCTNode = class CCTNode extends WebInspector.Object

I'm sad this is WebInspector.CCTNode and not WebInspector.CallingContextTreeNode. Also it should be a separate file? Good for a follow up.

> Source/WebInspectorUI/UserInterface/Views/ProfileView.js:172
> +            let nodeToSelect = this._dataGrid.findNode((node) => node.callingContextTreeNode.hash === this._sharedData.selectedNodeHash, skipHidden, stayWithin, dontPopulate)

Missing semicolon.

[Joseph Pecoraro]

Created attachment 283682 [details]
[PATCH] For Landing

[WebKit Commit Bot]

Comment on attachment 283682 [details]
[PATCH] For Landing

Clearing flags on attachment: 283682

Committed r203243: <http://trac.webkit.org/changeset/203243>