Bug 159778 - Web Inspector: Maintain selected function when switching between different profile representations
Summary: Web Inspector: Maintain selected function when switching between different pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-14 12:57 PDT by Joseph Pecoraro
Modified: 2016-07-18 14:14 PDT (History)
7 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (7.56 KB, patch)
2016-07-14 13:01 PDT, Joseph Pecoraro
timothy: review+
Details | Formatted Diff | Diff
[PATCH] For Landing (7.56 KB, patch)
2016-07-14 14:13 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-07-14 12:57:11 PDT
Summary:
Maintain selected function when switching between different profile representations.

Steps to Reproduce:
1. Inspect a page
2. Record a Timeline Profile with Scripts
3. Show Profile View
4. Select a function with Self Time
5. Toggle Inverted
  => Expected function to still be selected
6. Change Timeline Range selection slightly
  => Expected selection to stay the same

Notes:
- New up will be remembering expanded states, but remembering selection is a good first step.
Comment 1 Radar WebKit Bug Importer 2016-07-14 12:57:31 PDT
<rdar://problem/27355913>
Comment 2 Joseph Pecoraro 2016-07-14 13:01:42 PDT
Created attachment 283671 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2016-07-14 14:03:43 PDT
Comment on attachment 283671 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=283671&action=review

> Source/WebInspectorUI/UserInterface/Models/CallingContextTree.js:171
>  WebInspector.CCTNode = class CCTNode extends WebInspector.Object

I'm sad this is WebInspector.CCTNode and not WebInspector.CallingContextTreeNode. Also it should be a separate file? Good for a follow up.

> Source/WebInspectorUI/UserInterface/Views/ProfileView.js:172
> +            let nodeToSelect = this._dataGrid.findNode((node) => node.callingContextTreeNode.hash === this._sharedData.selectedNodeHash, skipHidden, stayWithin, dontPopulate)

Missing semicolon.
Comment 4 Joseph Pecoraro 2016-07-14 14:13:53 PDT
Created attachment 283682 [details]
[PATCH] For Landing
Comment 5 WebKit Commit Bot 2016-07-14 14:43:30 PDT
Comment on attachment 283682 [details]
[PATCH] For Landing

Clearing flags on attachment: 283682

Committed r203243: <http://trac.webkit.org/changeset/203243>