Bug 159770 - Fix the --minimal build fail in InjectedBundle.cpp
Summary: Fix the --minimal build fail in InjectedBundle.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Reported: 2016-07-14 09:11 PDT by Csaba Osztrogonác
Modified: 2016-07-18 23:51 PDT (History)
5 users (show)

See Also:

Patch (1.55 KB, patch)
2016-07-14 09:14 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-07-14 09:11:15 PDT
build-webkit --minimal fails with the following error message:
../../Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:197:9: error: 'RuntimeEnabledFeatures' has not been declared
../../Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:200:9: error: 'RuntimeEnabledFeatures' has not been declared

The problem is that RuntimeEnabledFeatures.h is included inside if guards,
but used unconditionally in these lines. I can't see any good reason to
include any header unconditionally, let's remove these guards to fix the build.
Comment 1 Csaba Osztrogonác 2016-07-14 09:14:36 PDT
Created attachment 283651 [details]
Comment 2 Csaba Osztrogonác 2016-07-15 06:37:25 PDT
note: revealed by http://trac.webkit.org/changeset/202091 :
     if (preference == "WebKitShadowDOMEnabled")

Now shadow DOM is used unconditionally and we need 
to include RuntimeEnabledFeatures.h always.
Comment 3 WebKit Commit Bot 2016-07-18 23:50:57 PDT
Comment on attachment 283651 [details]

Clearing flags on attachment: 283651

Committed r203398: <http://trac.webkit.org/changeset/203398>
Comment 4 WebKit Commit Bot 2016-07-18 23:51:01 PDT
All reviewed patches have been landed.  Closing bug.