Bug 159750 - Modernize WebSocket handle
Summary: Modernize WebSocket handle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-13 17:17 PDT by Alex Christensen
Modified: 2016-07-14 00:06 PDT (History)
0 users

See Also:

Attachments
Patch (25.37 KB, patch)
2016-07-13 17:21 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (26.82 KB, patch)
2016-07-13 23:51 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-07-13 17:17:07 PDT 
Modernize WebSocket handle
Comment 1 Alex Christensen 2016-07-13 17:21:31 PDT 
Created attachment 283591 [details]
Patch
Comment 2 Brady Eidson 2016-07-13 17:30:03 PDT 
Comment on attachment 283591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283591&action=review

> Source/WebCore/ChangeLog:9
> +        This patch just removes ThreadableWebSocketChannel::InvalidMessage which is never used

It's problematic this was never used.

Can we do some archeology and find out why? (e.g., was it used at one time, and that use was just dropped inadvertently?)
Comment 3 Alex Christensen 2016-07-13 17:48:29 PDT 
InvalidMessage was introduced but not used in https://bugs.webkit.org/show_bug.cgi?id=80356
It was used in https://bugs.webkit.org/show_bug.cgi?id=80103
It was removed sometime.
Comment 4 Alex Christensen 2016-07-13 23:51:29 PDT 
Created attachment 283608 [details]
Patch
Comment 5 Alex Christensen 2016-07-14 00:06:54 PDT 
https://trac.webkit.org/changeset/203217