Bug 159745 - Web Inspector: SidebarPanel classes should use View.layout instead of "refresh"
Summary: Web Inspector: SidebarPanel classes should use View.layout instead of "refresh"
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
Keywords: InRadar
Depends on:
Blocks: 159787
  Show dependency treegraph
Reported: 2016-07-13 16:23 PDT by Matt Baker
Modified: 2016-07-14 16:38 PDT (History)
7 users (show)

See Also:

[Patch] Proposed Fix (14.71 KB, patch)
2016-07-13 16:57 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-07-13 16:23:09 PDT
Currently sidebars use a refresh/needsRefresh idiom that parallels view's layout/needsLayout. Since sidebars inherit from View, we should clean this up.
Comment 1 Radar WebKit Bug Importer 2016-07-13 16:23:25 PDT
Comment 2 Matt Baker 2016-07-13 16:57:19 PDT
Created attachment 283588 [details]
[Patch] Proposed Fix
Comment 3 WebKit Commit Bot 2016-07-14 16:38:25 PDT
Comment on attachment 283588 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 283588

Committed r203253: <http://trac.webkit.org/changeset/203253>
Comment 4 WebKit Commit Bot 2016-07-14 16:38:29 PDT
All reviewed patches have been landed.  Closing bug.