Bug 159730 - Add more candidate tests
Summary: Add more candidate tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-13 11:54 PDT by Beth Dakin
Modified: 2016-07-13 13:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (21.98 KB, patch)
2016-07-13 12:25 PDT, Beth Dakin 		no flags Details | Formatted Diff | Diff
Patch (21.58 KB, patch)
2016-07-13 12:30 PDT, Beth Dakin 		no flags Details | Formatted Diff | Diff
Patch (21.58 KB, patch)
2016-07-13 12:40 PDT, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2016-07-13 11:54:44 PDT 
Add more candidate tests
Comment 1 Beth Dakin 2016-07-13 12:25:25 PDT 
Created attachment 283558 [details]
Patch
Comment 2 Beth Dakin 2016-07-13 12:30:55 PDT 
Created attachment 283559 [details]
Patch
Comment 3 WebKit Commit Bot 2016-07-13 12:32:40 PDT 
Attachment 283559 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/mac/CandidateTests.mm:107:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/mac/CandidateTests.mm:128:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Beth Dakin 2016-07-13 12:40:15 PDT 
Created attachment 283560 [details]
Patch
Comment 5 Beth Dakin 2016-07-13 13:53:29 PDT 
Thanks Tim! https://trac.webkit.org/changeset/203186