Bug 159725 – WebKit2 shouldn't signal custom protocol clients from the NSURLConnection loader thread.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

WebKit2 shouldn't signal custom protocol clients from the NSURLConnection loader thread.

[Chris Dumez]

<rdar://problem/27323131>

[Chris Dumez]

Created attachment 283543 [details]
Patch

[WebKit Commit Bot]

Attachment 283543 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:69:  Should not have spaces around = in property synthesis.  [whitespace/property] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Comment on attachment 283543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283543&action=review

> Source/WebKit2/NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:60
> +    CFRunLoopRef _initializationRunLoop;

I'd use a RetainPtr for this.

> Source/WebKit2/NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:95
> +    _initializationRunLoop = CFRunLoopGetCurrent();

This needs to be retained.

[Chris Dumez]

Created attachment 283561 [details]
Patch

[Andy Estes]

Comment on attachment 283561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283561&action=review

> Source/WebKit2/NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:197
> -    CFRunLoopPerformBlock([NSURLConnection resourceLoaderRunLoop], kCFRunLoopDefaultMode, block);
> -    CFRunLoopWakeUp([NSURLConnection resourceLoaderRunLoop]);
> +    CFRunLoopPerformBlock(protocol.initializationRunLoop, kCFRunLoopDefaultMode, block);
> +    CFRunLoopWakeUp(protocol.initializationRunLoop);

Nit: It'd be slightly nicer to store protocol.initializationRunLoop in a local variable.

[Chris Dumez]

Comment on attachment 283561 [details]
Patch

I'll fix the nit.

[Chris Dumez]

Created attachment 283562 [details]
Patch

[Chris Dumez]

Comment on attachment 283562 [details]
Patch

Clearing flags on attachment: 283562

Committed r203174: <http://trac.webkit.org/changeset/203174>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.