WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
159710
Test WTF.StringViewIterators is crashing since
r203119
https://bugs.webkit.org/show_bug.cgi?id=159710
Summary
Test WTF.StringViewIterators is crashing since r203119
Carlos Garcia Campos
Reported
2016-07-13 03:53:35 PDT
I think there are two problems in the test case added in
r203119
. First is that it's testing StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a const reference to the string view member of the deleted CodePoints object.
Attachments
Patch
(1.56 KB, patch)
2016-07-13 03:55 PDT
,
Carlos Garcia Campos
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2016-07-13 03:55:05 PDT
Created
attachment 283508
[details]
Patch
Myles C. Maxfield
Comment 2
2016-07-13 12:16:59 PDT
Wow... whoops. Thanks so much for fixing this.
Carlos Garcia Campos
Comment 3
2016-07-13 23:18:31 PDT
Committed
r203214
: <
http://trac.webkit.org/changeset/203214
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug