Bug 159701 – Clean up PassRefPtr uses in Modules/encryptedmedia, Modules/speech, and Modules/quota

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

SSIA

[Gyuyoung Kim]

Created attachment 283490 [details]
Patch

[Gyuyoung Kim]

Created attachment 283501 [details]
Patch

[Alex Christensen]

Comment on attachment 283501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283501&action=review

> Source/WebCore/Modules/quota/StorageErrorCallback.cpp:45
> -StorageErrorCallback::CallbackTask::CallbackTask(PassRefPtr<StorageErrorCallback> callback, ExceptionCode ec)
> +StorageErrorCallback::CallbackTask::CallbackTask(StorageErrorCallback* callback, ExceptionCode ec)
>      : ScriptExecutionContext::Task([callback, ec] (ScriptExecutionContext*) {
>          if (callback)
>              callback->handleEvent(DOMCoreException::create(ExceptionCodeDescription(ec)).get());

This feels like it should be a RefPtr<StorageErrorCallback>&& that is WTFMoved into the lambda so we are sure there is still a reference when we call the callback.  Otherwise, it's not obvious that there couldn't be a use after free.

> Source/WebCore/Modules/speech/SpeechSynthesis.cpp:189
> +void SpeechSynthesis::boundaryEventOccurred(PlatformSpeechSynthesisUtterance* utterance, SpeechBoundary boundary, unsigned charIndex)

This should definitely be a PlatformSpeechSynthesisUtterance&

> Source/WebCore/Modules/speech/SpeechSynthesis.cpp:209
> +void SpeechSynthesis::didStartSpeaking(PlatformSpeechSynthesisUtterance* utterance)

ditto

> Source/WebCore/Modules/speech/SpeechSynthesis.cpp:215
> +void SpeechSynthesis::didPauseSpeaking(PlatformSpeechSynthesisUtterance* utterance)

ditto

> Source/WebCore/Modules/speech/SpeechSynthesis.cpp:235
> +void SpeechSynthesis::speakingErrorOccurred(PlatformSpeechSynthesisUtterance* utterance)

etc.

> Source/WebCore/Modules/speech/SpeechSynthesisVoice.h:53
>      RefPtr<PlatformSpeechSynthesisVoice> m_platformVoice;

This should be made a Ref.

[Gyuyoung Kim]

Created attachment 283621 [details]
Patch

[Gyuyoung Kim]

Created attachment 283748 [details]
Patch

[Alex Christensen]

Comment on attachment 283748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283748&action=review

> Source/WebCore/Modules/speech/SpeechSynthesisVoice.cpp:39
> +SpeechSynthesisVoice::SpeechSynthesisVoice(PlatformSpeechSynthesisVoice* voice)
> +    : m_platformVoice(adoptRef(*voice))

This should be a PlatformSpeechSynthesisVoice&.  PlatformSpeechSynthesizer.m_voiceList should be Refs.

[Build Bot]

Comment on attachment 283748 [details]
Patch

Attachment 283748 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1694508

New failing tests:
transitions/default-timing-function.html

[Build Bot]

Created attachment 283859 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Gyuyoung Kim]

Created attachment 283881 [details]
Patch for landing

[Gyuyoung Kim]

Comment on attachment 283881 [details]
Patch for landing

Looks like win-ews is being failed regardless of this patch.

[WebKit Commit Bot]

Comment on attachment 283881 [details]
Patch for landing

Clearing flags on attachment: 283881

Committed r203340: <http://trac.webkit.org/changeset/203340>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.