Bug 159671 - Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
Summary: Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 89235
  Show dependency tree / graph
 
Reported: 2016-07-12 02:00 PDT by Gyuyoung Kim
Modified: 2016-07-12 07:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (34.83 KB, patch)
2016-07-12 02:07 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (41.80 KB, patch)
2016-07-12 02:11 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (42.16 KB, patch)
2016-07-12 05:43 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2016-07-12 02:00:43 PDT 
r144214 only added ENABLE_CSS3_TEXT_LINE_BREAK flag though, there has been no concrete implementation until now. This patch removes it in order to clean up unused flags.
Comment 1 Gyuyoung Kim 2016-07-12 02:07:11 PDT 
Created attachment 283400 [details]
Patch
Comment 2 WebKit Commit Bot 2016-07-12 02:08:24 PDT 
Attachment 283400 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig).  [featuredefines/equality] [5]
ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig).  [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig).  [featuredefines/equality] [5]
ERROR: Source/WebKit2/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig).  [featuredefines/equality] [5]
Total errors found: 4 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2016-07-12 02:11:39 PDT 
Created attachment 283401 [details]
Patch
Comment 4 Csaba Osztrogonác 2016-07-12 03:51:12 PDT 
Comment on attachment 283401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283401&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        r144214 only added ENABLE_CSS3_TEXT_LINE_BREAK flag though, there has been no concrete implementation until now.

I think it is completed and used unconditionally - https://bugs.webkit.org/show_bug.cgi?id=89235
Comment 5 Csaba Osztrogonác 2016-07-12 03:53:33 PDT 
Comment on attachment 283401 [details]
Patch

rs=me, but please fix the comment before landing.
Comment 6 Gyuyoung Kim 2016-07-12 05:43:42 PDT 
Created attachment 283402 [details]
Patch for landing
Comment 7 Gyuyoung Kim 2016-07-12 05:44:35 PDT 
(In reply to comment #4)
> Comment on attachment 283401 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=283401&action=review
> 
> > Source/JavaScriptCore/ChangeLog:8
> > +        r144214 only added ENABLE_CSS3_TEXT_LINE_BREAK flag though, there has been no concrete implementation until now.
> 
> I think it is completed and used unconditionally -
> https://bugs.webkit.org/show_bug.cgi?id=89235

Ah, I missed this bug. Thank you for pointing it out. Fixed the descriptions in ChangeLogs.
Comment 8 WebKit Commit Bot 2016-07-12 06:24:15 PDT 
The commit-queue encountered the following flaky tests while processing attachment 283402 [details]:

The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2016-07-12 06:24:44 PDT 
The commit-queue encountered the following flaky tests while processing attachment 283402 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2016-07-12 07:37:20 PDT 
Comment on attachment 283402 [details]
Patch for landing

Clearing flags on attachment: 283402

Committed r203115: <http://trac.webkit.org/changeset/203115>
Comment 11 WebKit Commit Bot 2016-07-12 07:37:25 PDT 
All reviewed patches have been landed.  Closing bug.