Bug 159667 – [GStreamer] bump required version to 1.2.3

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Philippe Normand]

1.2.3 is the version used in Ubuntu 14.04 LTS.

If we don't bother about Ubuntu we can bump to 1.4.4 though, which is the version shipped in Debian current stable (Jessie).

https://packages.debian.org/search?keywords=libgstreamer1.0&searchon=names&suite=all&section=all
http://packages.ubuntu.com/search?keywords=libgstreamer1.0&searchon=names&suite=all&section=all
https://apps.fedoraproject.org/packages/gstreamer1

Thoughts?

[Philippe Normand]

Created attachment 283396 [details]
patch

[Philippe Normand]

Created attachment 283397 [details]
patch

[Martin Robinson]

I think we need to discuss this before landing it.

[Philippe Normand]

(In reply to comment #3)
> I think we need to discuss this before landing it.

Agreed :)

Any feedback about the initial description of this bug?

[Philippe Normand]

Maintaining the code path for the old version isn't so much of a maintenance burden but the reality is that I doubt anyone actually use that version anymore. I actually haven't tried that in a long time, and don't know if it still works.

So I propose to remove this support, if anyone still needs this they'll likely complain and then maybe we can revert the change.

[Xabier Rodríguez Calvar]

(In reply to comment #5)
> Maintaining the code path for the old version isn't so much of a maintenance
> burden but the reality is that I doubt anyone actually use that version
> anymore. I actually haven't tried that in a long time, and don't know if it
> still works.
> 
> So I propose to remove this support, if anyone still needs this they'll
> likely complain and then maybe we can revert the change.

I agree

[Csaba Osztrogonác]

Comment on attachment 283397 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283397&action=review

> Source/WebCore/ChangeLog:12
> +        GStreamer 1.0.3 was released almost 4 years ago. GStreamer 1.2.3
> +        being the version shipped in the current Ubuntu LTS (14.04) it
> +        feels reasonable to bump our requirement. Other major
> +        distributions like Debian Jessie and Fedora ship GStreamer 1.4.x
> +        already.

Just a note: the latest Ubuntu LTS 16.04 shipped GStreamer 1.8.0.

[Philippe Normand]

(In reply to comment #7)
> Comment on attachment 283397 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=283397&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        GStreamer 1.0.3 was released almost 4 years ago. GStreamer 1.2.3
> > +        being the version shipped in the current Ubuntu LTS (14.04) it
> > +        feels reasonable to bump our requirement. Other major
> > +        distributions like Debian Jessie and Fedora ship GStreamer 1.4.x
> > +        already.
> 
> Just a note: the latest Ubuntu LTS 16.04 shipped GStreamer 1.8.0.

Yes but sadly I suspect 14.04 is still widely used :/

[Philippe Normand]

The ChangeLog can indeed be improved a bit though :)

[Philippe Normand]

I'm not sure an agreement was reached on the mailing list. Can this patch land soon?

[Michael Catanzaro]

This won't cause problems for any distros. You've got r+, you can go ahead.

[Philippe Normand]

Committed r205180: <http://trac.webkit.org/changeset/205180>