Bug 159665 – [JSC] Convert the remaining createOutOfMemoryError()+throwException() into throwOutOfMemoryError()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

[JSC] Convert the remaining createOutOfMemoryError()+throwException() into throwOutOfMemoryError()

[Benjamin Poulain]

Created attachment 283388 [details]
Patch

[Build Bot]

Comment on attachment 283388 [details]
Patch

Attachment 283388 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1667043

New failing tests:
js/array-splice.html
js/dom/concat-large-strings-crash2.html
js/stringimpl-to-jsstring-on-large-strings-1.html
fast/canvas/webgl/array-unit-tests.html
webgl/1.0.2/conformance/typedarrays/array-unit-tests.html
fast/canvas/webgl/arraybuffer-transfer-of-control.html
webgl/1.0.2/conformance/typedarrays/data-view-crash.html
js/dom/concat-large-strings-crash.html
js/dom/string-replacement-outofmemory.html

[Build Bot]

Created attachment 283390 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 283388 [details]
Patch

Attachment 283388 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1667049

New failing tests:
js/array-splice.html
js/dom/concat-large-strings-crash2.html
js/stringimpl-to-jsstring-on-large-strings-1.html
webgl/1.0.2/conformance/typedarrays/array-unit-tests.html
js/dom/concat-large-strings-crash.html
js/dom/string-replacement-outofmemory.html

[Build Bot]

Created attachment 283391 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 283388 [details]
Patch

Attachment 283388 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1667053

New failing tests:
js/array-splice.html
js/dom/concat-large-strings-crash2.html
js/dom/string-replacement-outofmemory.html
fast/canvas/webgl/array-unit-tests.html
webgl/1.0.2/conformance/typedarrays/array-unit-tests.html
js/dom/concat-large-strings-crash.html
js/stringimpl-to-jsstring-on-large-strings-1.html

[Build Bot]

Created attachment 283392 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Mark Lam]

Comment on attachment 283388 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283388&action=review

> Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:294
> -    return exec->vm().throwException(exec, createOutOfMemoryError(exec));
> +    return throwOutOfMemoryError(exec);

Infinite recursion here.  Please fix.

[Benjamin Poulain]

Created attachment 283458 [details]
Patch

[Saam Barati]

Comment on attachment 283458 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 283458 [details]
Patch

Clearing flags on attachment: 283458

Committed r203320: <http://trac.webkit.org/changeset/203320>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.