Bug 159665 - [JSC] Convert the remaining createOutOfMemoryError()+throwException() into throwOutOfMemoryError()
Summary: [JSC] Convert the remaining createOutOfMemoryError()+throwException() into th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-11 23:01 PDT by Benjamin Poulain
Modified: 2016-07-15 21:17 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.29 KB, patch)
2016-07-11 23:02 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.19 MB, application/zip)
2016-07-12 00:05 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.15 MB, application/zip)
2016-07-12 00:09 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.88 MB, application/zip)
2016-07-12 00:15 PDT, Build Bot 		no flags Details
Patch (6.69 KB, patch)
2016-07-12 15:23 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-07-11 23:01:45 PDT 
[JSC] Convert the remaining createOutOfMemoryError()+throwException() into throwOutOfMemoryError()
Comment 1 Benjamin Poulain 2016-07-11 23:02:08 PDT 
Created attachment 283388 [details]
Patch
Comment 2 Build Bot 2016-07-12 00:05:08 PDT 
Comment on attachment 283388 [details]
Patch

Attachment 283388 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1667043

New failing tests:
js/array-splice.html
js/dom/concat-large-strings-crash2.html
js/stringimpl-to-jsstring-on-large-strings-1.html
fast/canvas/webgl/array-unit-tests.html
webgl/1.0.2/conformance/typedarrays/array-unit-tests.html
fast/canvas/webgl/arraybuffer-transfer-of-control.html
webgl/1.0.2/conformance/typedarrays/data-view-crash.html
js/dom/concat-large-strings-crash.html
js/dom/string-replacement-outofmemory.html
Comment 3 Build Bot 2016-07-12 00:05:11 PDT 
Created attachment 283390 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-07-12 00:09:11 PDT 
Comment on attachment 283388 [details]
Patch

Attachment 283388 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1667049

New failing tests:
js/array-splice.html
js/dom/concat-large-strings-crash2.html
js/stringimpl-to-jsstring-on-large-strings-1.html
webgl/1.0.2/conformance/typedarrays/array-unit-tests.html
js/dom/concat-large-strings-crash.html
js/dom/string-replacement-outofmemory.html
Comment 5 Build Bot 2016-07-12 00:09:14 PDT 
Created attachment 283391 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-07-12 00:15:05 PDT 
Comment on attachment 283388 [details]
Patch

Attachment 283388 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1667053

New failing tests:
js/array-splice.html
js/dom/concat-large-strings-crash2.html
js/dom/string-replacement-outofmemory.html
fast/canvas/webgl/array-unit-tests.html
webgl/1.0.2/conformance/typedarrays/array-unit-tests.html
js/dom/concat-large-strings-crash.html
js/stringimpl-to-jsstring-on-large-strings-1.html
Comment 7 Build Bot 2016-07-12 00:15:09 PDT 
Created attachment 283392 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Mark Lam 2016-07-12 10:13:38 PDT 
Comment on attachment 283388 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283388&action=review

> Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:294
> -    return exec->vm().throwException(exec, createOutOfMemoryError(exec));
> +    return throwOutOfMemoryError(exec);

Infinite recursion here.  Please fix.
Comment 9 Benjamin Poulain 2016-07-12 15:23:22 PDT 
Created attachment 283458 [details]
Patch
Comment 10 Saam Barati 2016-07-15 18:44:28 PDT 
Comment on attachment 283458 [details]
Patch

r=me
Comment 11 WebKit Commit Bot 2016-07-15 21:17:21 PDT 
Comment on attachment 283458 [details]
Patch

Clearing flags on attachment: 283458

Committed r203320: <http://trac.webkit.org/changeset/203320>
Comment 12 WebKit Commit Bot 2016-07-15 21:17:25 PDT 
All reviewed patches have been landed.  Closing bug.