Bug 159661 – REGRESSION (202694): Audio and Video playback controls: Cannot find a position slider to adjust playback position using VO.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Dean Jackson]

The change in r202694 broke the visibility of the scrubber in MediaDocuments.

[Dean Jackson]

<rdar://problem/27285135>

[Dean Jackson]

Created attachment 283384 [details]
Patch

[Eric Carlson]

Comment on attachment 283384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283384&action=review

> LayoutTests/media/controls/default-size-should-show-scrubber.html:11
> +let tester = new ControlsTest()

Nit: this can be a const

> LayoutTests/media/controls/default-size-should-show-scrubber.html:37
> +        let elementState = tester.stateForControlsElement(name);

Ditto.

[Eric Carlson]

Comment on attachment 283384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283384&action=review

> LayoutTests/media/controls/default-size-should-show-scrubber.html:6
> +    if (state === null || typeof state.className !== "string")
> +        return false;

Don't you want to return true here?

> LayoutTests/media/controls/default-size-should-show-scrubber.html:7
> +    let classes = state.className.split();

Nit: this can be a const.

[Dean Jackson]

Committed r203120: <http://trac.webkit.org/changeset/203120>

[Ryan Haddad]

The test added with this change is frequently failing on El Capitan Debug WK2

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fcontrols%2Fdefault-size-should-show-scrubber.html

[Ryan Haddad]

(In reply to comment #6)
> The test added with this change is frequently failing on El Capitan Debug WK2
> 
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=media%2Fcontrols%2Fdefault-size-should-show-
> scrubber.html

Direct link to a failure:

https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/6506