Bug 159652 - SVN.create_patch should find svn-create-patch relative to the WebKit root.
Summary: SVN.create_patch should find svn-create-patch relative to the WebKit root.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-11 16:08 PDT by Jason Marcell
Modified: 2016-07-11 17:25 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2016-07-11 16:10 PDT, Jason Marcell 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Marcell 2016-07-11 16:08:21 PDT 
SVN.create_patch should find svn-create-patch relative to the WebKit root.
Comment 1 Jason Marcell 2016-07-11 16:10:10 PDT 
Created attachment 283360 [details]
Patch
Comment 2 Daniel Bates 2016-07-11 16:19:44 PDT 
Comment on attachment 283360 [details]
Patch

r=me
Comment 3 Daniel Bates 2016-07-11 16:20:35 PDT 
Comment on attachment 283360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283360&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:42
> +from webkitpy.common.webkit_finder import WebKitFinder
>  from webkitpy.common.memoized import memoized
>  from webkitpy.common.system.executive import Executive, ScriptError
>  from webkitpy.common.config.urls import svn_server_host, svn_server_realm

Please sort these imports with respect to the UNIX sort command.
Comment 4 Jason Marcell 2016-07-11 17:25:54 PDT 
Landed: https://trac.webkit.org/changeset/203095