Bug 159648 – [WK2][iOS] Intermittent crash in [UIApplication beginBackgroundTaskWithName] expiration handler

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

We see an intermittent crash in [UIApplication beginBackgroundTaskWithName] expiration handler. From the traces, we noticed the expiration handler can get called on a non-main thread under certain conditions, which our code is designed to deal with.

[Chris Dumez]

<rdar://problem/27219361>

[Chris Dumez]

Created attachment 283352 [details]
Patch

[Daniel Bates]

Comment on attachment 283352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283352&action=review

> Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:101
> +            if (RunLoop::current().isMain()) {

We can make use of the convenience function RunLoop::isMain() to simplify the if-expression.

[Chris Dumez]

Created attachment 283355 [details]
Patch

[Anders Carlsson]

Wouldn't it be better to just always dispatch to the main thread? This will break if the UIKit semantics change.

[Chris Dumez]

Created attachment 283359 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 283359 [details]
Patch

Clearing flags on attachment: 283359

Committed r203094: <http://trac.webkit.org/changeset/203094>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.