Bug 159623 – Move parsing of display, displaystyle and mathvariant attributes from rendering to mathml element classes

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Frédéric Wang (:fredw)]

This is bug 156536 for the attributes parsed in rendering/mathml/MathMLStyle.cpp

[Frédéric Wang (:fredw)]

Created attachment 284101 [details]
Patch (applies after bug 159625)

[Frédéric Wang (:fredw)]

Created attachment 284102 [details]
Patch bug 159625 + 159623 (for EWS testing)

[Frédéric Wang (:fredw)]

Created attachment 284307 [details]
Patch

[Brent Fulgham]

Comment on attachment 284307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284307&action=review

> Source/WebCore/mathml/MathMLElement.cpp:589
> +void MathMLElement::getSpecifiedDisplayStyle(bool& displayStyle)

We avoid using 'get' names in WebKit. This should be called "specifiedDisplayStyle".

> Source/WebCore/mathml/MathMLElement.cpp:598
> +void MathMLElement::getSpecifiedMathVariant(MathMLElement::MathVariant& mathVariant)

Ditto. We should probably call this "specifiedMathVariant"

[Brent Fulgham]

Comment on attachment 284307 [details]
Patch

Looks great! Thanks.

[Darin Adler]

Comment on attachment 284307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284307&action=review

>> Source/WebCore/mathml/MathMLElement.cpp:589
>> +void MathMLElement::getSpecifiedDisplayStyle(bool& displayStyle)
> 
> We avoid using 'get' names in WebKit. This should be called "specifiedDisplayStyle".

We actually reserve the use of get for functions with out arguments. And there is an out argument here. But it’s peculiar how this works; it sets the argument to true or false, or possibly leaves the argument alone in other cases. I don’t think the name "get" makes that kind of unconventional behavior clear enough.

I think it would be clearer to use a return type of Optional<bool> for clarity even if that usage is less economical at the call site. Then the function would indeed be named specifiedDisplayStyle.

>> Source/WebCore/mathml/MathMLElement.cpp:598
>> +void MathMLElement::getSpecifiedMathVariant(MathMLElement::MathVariant& mathVariant)
> 
> Ditto. We should probably call this "specifiedMathVariant"

Same comment as above.

[Frédéric Wang (:fredw)]

Committed r203679: <http://trac.webkit.org/changeset/203679>