Bug 159601 - appendMemcpy might fail in concatAppendOne
Summary: appendMemcpy might fail in concatAppendOne
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-09 11:45 PDT by Keith Miller
Modified: 2016-07-09 13:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.82 KB, patch)
2016-07-09 12:13 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (6.55 KB, patch)
2016-07-09 13:13 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (6.55 KB, patch)
2016-07-09 13:20 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-07-09 11:45:56 PDT 
appendMemcpy might fail in concatAppendOne
Comment 1 Keith Miller 2016-07-09 12:13:01 PDT 
Created attachment 283264 [details]
Patch
Comment 2 Mark Lam 2016-07-09 12:59:12 PDT 
Comment on attachment 283264 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283264&action=review

r=me if perf checks out.  Also please rename the test to concat-with-holesMustForwardToPrototype.js since the issue is with arrays that have the holesMustForwardToPrototype attribute.

> Source/JavaScriptCore/ChangeLog:10
> +        a one of the Array prototypes has an index property. This patch

typo: "a one" => "one".
Comment 3 Keith Miller 2016-07-09 13:13:36 PDT 
Created attachment 283266 [details]
Patch for landing
Comment 4 Keith Miller 2016-07-09 13:20:01 PDT 
rdar://problem/27211300
Comment 5 Keith Miller 2016-07-09 13:20:53 PDT 
Created attachment 283267 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2016-07-09 13:51:32 PDT 
Comment on attachment 283267 [details]
Patch for landing

Clearing flags on attachment: 283267

Committed r203033: <http://trac.webkit.org/changeset/203033>
Comment 7 WebKit Commit Bot 2016-07-09 13:51:36 PDT 
All reviewed patches have been landed.  Closing bug.