Bug 159592 - Use refs for ResourceLoaders
Summary: Use refs for ResourceLoaders
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on: 159642
Blocks:
  Show dependency tree / graph
 
Reported: 2016-07-08 17:32 PDT by Alex Christensen
Modified: 2016-07-11 13:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (26.96 KB, patch)
2016-07-08 17:33 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (1.10 MB, application/zip)
2016-07-08 18:34 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews116 for mac-yosemite (1.66 MB, application/zip)
2016-07-08 18:51 PDT, Build Bot 		no flags Details
Patch (27.01 KB, patch)
2016-07-08 22:40 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (26.68 KB, patch)
2016-07-08 23:10 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (27.46 KB, patch)
2016-07-09 15:23 PDT, Alex Christensen 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-07-08 17:32:52 PDT 
Use refs for ResourceLoaders
Comment 1 Alex Christensen 2016-07-08 17:33:43 PDT 
Created attachment 283232 [details]
Patch
Comment 2 Build Bot 2016-07-08 18:34:38 PDT 
Comment on attachment 283232 [details]
Patch

Attachment 283232 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1649693

New failing tests:
webarchive/loading/cache-expired-subresource.html
http/tests/appcache/foreign-fallback.html
http/tests/appcache/main-resource-fallback-for-network-error-crash.html
http/tests/appcache/fallback.html
Comment 3 Build Bot 2016-07-08 18:34:42 PDT 
Created attachment 283235 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-07-08 18:51:47 PDT 
Comment on attachment 283232 [details]
Patch

Attachment 283232 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1649713

New failing tests:
webarchive/loading/cache-expired-subresource.html
http/tests/appcache/foreign-fallback.html
http/tests/appcache/main-resource-fallback-for-network-error-crash.html
http/tests/appcache/fallback.html
Comment 5 Build Bot 2016-07-08 18:51:51 PDT 
Created attachment 283237 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Alex Christensen 2016-07-08 22:40:53 PDT 
Created attachment 283245 [details]
Patch
Comment 7 Alex Christensen 2016-07-08 23:10:35 PDT 
Created attachment 283246 [details]
Patch
Comment 8 Chris Dumez 2016-07-09 08:19:06 PDT 
Does not build on iOS?
Comment 9 Chris Dumez 2016-07-09 08:33:01 PDT 
Comment on attachment 283246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283246&action=review

> Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.h:108
>      typedef HashMap<String, HostInformation*, StringHash> HostMap;

Still using a raw pointer here? It'd be nice to switch to unique_ptr<> since you're modifying this code.
Comment 10 Alex Christensen 2016-07-09 15:23:59 PDT 
Created attachment 283269 [details]
Patch
Comment 11 Chris Dumez 2016-07-10 09:53:39 PDT 
Comment on attachment 283269 [details]
Patch

r=me
Comment 12 Alex Christensen 2016-07-11 09:02:17 PDT 
https://trac.webkit.org/changeset/203064
Comment 13 WebKit Commit Bot 2016-07-11 13:08:58 PDT 
Re-opened since this is blocked by bug 159642
Comment 14 Ryan Haddad 2016-07-11 13:12:04 PDT 
(In reply to comment #13)
> Re-opened since this is blocked by bug 159642

<rdar://problem/27283181>