Bug 159584 - Add synthetic click origin to WKNavigationAction
Summary: Add synthetic click origin to WKNavigationAction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-08 16:18 PDT by Enrica Casucci
Modified: 2016-07-11 14:58 PDT (History)
9 users (show)

See Also:

Attachments
Path (61.66 KB, patch)
2016-07-08 16:28 PDT, Enrica Casucci 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2016-07-08 16:18:33 PDT 
Adding a private property to retrieve the origin of the synthetic click.

rdar://problem/25610422
Comment 1 Enrica Casucci 2016-07-08 16:28:55 PDT 
Created attachment 283215 [details]
Path
Comment 2 WebKit Commit Bot 2016-07-08 16:31:25 PDT 
Attachment 283215 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:70:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/PlatformMouseEvent.h:78:  Wrong number of spaces before statement. (expected: 31)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/DragController.cpp:108:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/mac/WebView/WebFrame.mm:980:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/MouseEvent.cpp:102:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/MouseEvent.cpp:111:  Wrong number of spaces before statement. (expected: 27)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/SimulatedClick.cpp:52:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 36 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2016-07-11 11:23:11 PDT 
Windows build error:

C:\cygwin\home\buildbot\WebKit\Source\WebKit\win\WebDropSource.cpp(104): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'WebCore::PlatformMouseEvent' [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKit\WebKit.vcxproj]
  C:\cygwin\home\buildbot\WebKit\Source\WebKit\win\WebDropSource.cpp(104): note: No constructor could take the source type, or constructor overload resolution was ambiguous
Comment 4 Enrica Casucci 2016-07-11 14:35:41 PDT 
Fixed the windows build before landing.
Committed revision 203085.
Comment 5 Ryan Haddad 2016-07-11 14:58:48 PDT 
(In reply to comment #4)
> Fixed the windows build before landing.
> Committed revision 203085.

This change still appears to have broken the Windows build:
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/79024