Bug 159571 - speculateTypedArrayIsNotNeutered has an inverted speculation
Summary: speculateTypedArrayIsNotNeutered has an inverted speculation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-08 11:41 PDT by Keith Miller
Modified: 2016-07-08 11:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2016-07-08 11:44 PDT, Keith Miller 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-07-08 11:41:33 PDT 
speculateTypedArrayIsNotNeutered has an inverted speculation
Comment 1 Keith Miller 2016-07-08 11:44:33 PDT 
Created attachment 283185 [details]
Patch
Comment 2 Mark Lam 2016-07-08 11:45:51 PDT 
Comment on attachment 283185 [details]
Patch

r=me

Got tests?
Comment 3 Keith Miller 2016-07-08 11:46:44 PDT 
(In reply to comment #2)
> Comment on attachment 283185 [details]
> Patch
> 
> r=me
> 
> Got tests?

It's already breaking tests on ToT but only if we eagerly FTL.
Comment 4 Mark Lam 2016-07-08 11:47:45 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 283185 [details]
> > Patch
> > 
> > r=me
> > 
> > Got tests?
> 
> It's already breaking tests on ToT but only if we eagerly FTL.

Can you add a comment in the ChangeLog about which tests will break?  Why is it not breaking on the test bots?  Do we need to change a config on that test?
Comment 5 Keith Miller 2016-07-08 11:49:06 PDT 
Committed r202997: <http://trac.webkit.org/changeset/202997>
Comment 6 Keith Miller 2016-07-08 11:51:22 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Comment on attachment 283185 [details]
> > > Patch
> > > 
> > > r=me
> > > 
> > > Got tests?
> > 
> > It's already breaking tests on ToT but only if we eagerly FTL.
> 
> Can you add a comment in the ChangeLog about which tests will break?  Why is
> it not breaking on the test bots?  Do we need to change a config on that
> test?

I'll make it clearer in the Changelog that there is already a test failing on the bots.