Bug 159567 – System proxy settings not used when building deps with jhbuild

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Olivier Blin]

The system proxy settings (dconf org.gnome.system.proxy) are not used by WebKitGTK when deps have been built through jhbuild.

[Olivier Blin]

Created attachment 283179 [details]
Patch

[Olivier Blin]

This is my first attempt, mostly for reference.
It enables dconf and gnome proxy modules in gio, in the jhbuild root.

The disadvantage is that it pulls dconf in the jhbuild modules for everyone, as pointed by Konstantin.

Fujii suggested instead to use the libproxy support in glib-networking.
I'll post a second patch to do that.

[Konstantin Tokarev]

I think there is no need to build libproxy with jhbuild, just add appropriate packages to Tools/gtk/install-dependencies (and also for EFL if you like). glib-networking activates proxy support automatically when building if libproxy headers are available.

[Olivier Blin]

(In reply to comment #3)
> I think there is no need to build libproxy with jhbuild, just add
> appropriate packages to Tools/gtk/install-dependencies (and also for EFL if
> you like). glib-networking activates proxy support automatically when
> building if libproxy headers are available.

Yes, that's what I plan to propose as a patch, once I get this working.

[Philippe Normand]

Not sure you saw this Wiki page?

https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy

I don't think we need a patch for this.

[Olivier Blin]

(In reply to comment #5)
> Not sure you saw this Wiki page?
> 
> https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
> 
> I don't think we need a patch for this.

I was not aware of this wiki page, building dconf this way is a good solution.
Though, on my system, this didn't work by default, since libgiognomeproxy.so was not built in glib-networking, because gsettings.m4 was not installed on my system.

What do you think of just adding the following in Tools/gtk/install-dependencies? 
- gsettings-desktop-schemas-dev: for gsettings.m4, to enable libgiognomeproxy.so in libnetworking
- libproxy-dev: to enable libgiolibproxy.so in glib-networking for generic proxy support, including through environment variables

libproxy support in glib-networking works for me without dconf, provided I unset GNOME_DESKTOP_SESSION_ID, in which case it uses the usual proxy environment variables (envvar libproxy module).

Otherwise, it uses the gnome3 libproxy module, which will use system proxy settings only if the libdconfsettings.so gio module is available in the jhbuild root.

[Michael Catanzaro]

Good investigation. I've never understood why we have so many different proxy modules.

(In reply to comment #6)
> What do you think of just adding the following in
> Tools/gtk/install-dependencies? 
> - gsettings-desktop-schemas-dev: for gsettings.m4, to enable
> libgiognomeproxy.so in libnetworking
> - libproxy-dev: to enable libgiolibproxy.so in glib-networking for generic
> proxy support, including through environment variables

Sounds good to me.

Please look up the Arch dependencies too; you can use the package search on https://www.archlinux.org/

[Olivier Blin]

Created attachment 283319 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 283319 [details]
Patch

Clearing flags on attachment: 283319

Committed r203069: <http://trac.webkit.org/changeset/203069>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.