Bug 159566 – Clearing LocalStorage doesn't also delete -wal and -shm files

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Clearing LocalStorage doesn't also delete -wal and -shm files

This regressed when we enabled WAL logging for our SQLite databases.

[Brady Eidson]

<rdar://problem/27206772>

[Brady Eidson]

Created attachment 283174 [details]
Patch

[Brady Eidson]

Created attachment 283175 [details]
Patch

[WebKit Commit Bot]

Attachment 283175 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:79:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Comment on attachment 283175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283175&action=review

> Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:340
> +    WebCore::SQLiteFileSystem::deleteDatabaseFile(path);

No need for the WebCore:: in this file.

> Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:346
> +        WebCore::SQLiteFileSystem::deleteDatabaseFile(trackerDatabasePath());

Ditto.

[Brent Fulgham]

Comment on attachment 283175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283175&action=review

Looks good. If the tests are happy, go ahead and land it! r=me.

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=159566

<rdar://problem/27206772>

> Source/WebKit2/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=159566

<rdar://problem/27206772>

> Tools/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=159566

<rdar://problem/27206772>

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:87
> +    }];

Nice test! :-)

[Brady Eidson]

https://trac.webkit.org/changeset/202984