Bug 159564 - Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
Summary: Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-08 09:35 PDT by youenn fablet
Modified: 2016-07-12 10:44 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.23 KB, patch)
2016-07-08 09:37 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-07-08 09:35:24 PDT
The option --with-wrapper-files should be changed to --wrappers
Comment 1 youenn fablet 2016-07-08 09:37:06 PDT
Created attachment 283173 [details]
Patch
Comment 2 youenn fablet 2016-07-08 09:56:03 PDT
I was thinking that bots were running builtin generation tests.
But it seems this is not the case, or not with the run-builtins-generator-tests at least.
It might be good to add such tests I guess.
Comment 3 BJ Burg 2016-07-12 10:21:43 PDT
Comment on attachment 283173 [details]
Patch

r=me
Comment 4 BJ Burg 2016-07-12 10:22:27 PDT
(In reply to comment #2)
> I was thinking that bots were running builtin generation tests.
> But it seems this is not the case, or not with the
> run-builtins-generator-tests at least.
> It might be good to add such tests I guess.

They don't. I've asked many times for other random test suites to run with EWS and bots.
Comment 5 youenn fablet 2016-07-12 10:25:03 PDT
(In reply to comment #4)
> (In reply to comment #2)
> > I was thinking that bots were running builtin generation tests.
> > But it seems this is not the case, or not with the
> > run-builtins-generator-tests at least.
> > It might be good to add such tests I guess.
> 
> They don't. I've asked many times for other random test suites to run with
> EWS and bots.

I'll prepare a patch for ESW.
As of bots, I also requested that, maybe it is just a matter of preparing a patch as well.
Comment 6 youenn fablet 2016-07-12 10:25:09 PDT
(In reply to comment #4)
> (In reply to comment #2)
> > I was thinking that bots were running builtin generation tests.
> > But it seems this is not the case, or not with the
> > run-builtins-generator-tests at least.
> > It might be good to add such tests I guess.
> 
> They don't. I've asked many times for other random test suites to run with
> EWS and bots.

I'll prepare a patch for ESW.
As of bots, I also requested that, maybe it is just a matter of preparing a patch as well.
Comment 7 WebKit Commit Bot 2016-07-12 10:44:14 PDT
Comment on attachment 283173 [details]
Patch

Clearing flags on attachment: 283173

Committed r203118: <http://trac.webkit.org/changeset/203118>
Comment 8 WebKit Commit Bot 2016-07-12 10:44:18 PDT
All reviewed patches have been landed.  Closing bug.