Bug 15951 - REGRESSION: assertion failure in regexp match() when running JS tests
Summary: REGRESSION: assertion failure in regexp match() when running JS tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-12 03:06 PST by Alexey Proskuryakov
Modified: 2007-11-12 16:25 PST (History)
2 users (show)

See Also:

Attachments
Reduction (206 bytes, text/plain)
2007-11-12 13:20 PST, Geoffrey Garen 		no flags Details
patch (4.35 KB, patch)
2007-11-12 14:25 PST, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2007-11-12 03:06:02 PST 
Running r27689 or r27710 debug build, not sure when this started or which test causes this.

Thread 0 Crashed:
0    match(unsigned short const*, unsigned char const*, int, match_data*) + 31087 (pcre_exec.cpp:1878)
1    jsRegExpExecute(JSRegExp const*, unsigned short const*, int, int, int*, int) + 1705 (pcre_exec.cpp:2272)
2    KJS::RegExp::match(KJS::UString const&, int, WTF::OwnArrayPtr<int>*) + 275 (regexp.cpp:105)
3    KJS::RegExpObjectImp::performMatch(KJS::RegExp*, KJS::UString const&, int, int&, int&, int**) + 64 (regexp_object.cpp:305)
4    KJS::StringProtoFuncSearch::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 395 (string_object.cpp:611)
5    KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 220 (object.cpp:95)
Comment 1 Darin Adler 2007-11-12 12:26:36 PST 
 Geoff was showing this to me today. Should be easy to fix.
Comment 2 Geoffrey Garen 2007-11-12 13:20:58 PST 
Created attachment 17209 [details]
Reduction
Comment 3 Geoffrey Garen 2007-11-12 13:21:28 PST 
This ASSERT fires only with > 100 parens. <= 100 parens won't do it.
Comment 4 Darin Adler 2007-11-12 14:25:48 PST 
Created attachment 17213 [details]
patch
Comment 5 Sam Weinig 2007-11-12 15:33:54 PST 
Comment on attachment 17213 [details]
patch

Looks good. r=me.
Comment 6 Darin Adler 2007-11-12 16:25:26 PST 
Committed revision 27733.