We should validate reason phrase as per https://tools.ietf.org/html/rfc7230#section-3.1.2
Created attachment 282999 [details] Patch
Comment on attachment 282999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282999&action=review > Source/WebCore/platform/network/HTTPParsers.cpp:105 > +bool isValidReasonPhrase(const String& value) The other functions like this have a comment. I think this needs one, too. // See RFC 7230, Section 3.1.2.
Created attachment 283017 [details] Patch for landing
Thanks for the review. (In reply to comment #2) > Comment on attachment 282999 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282999&action=review > > > Source/WebCore/platform/network/HTTPParsers.cpp:105 > > +bool isValidReasonPhrase(const String& value) > > The other functions like this have a comment. I think this needs one, too. > // See RFC 7230, Section 3.1.2. Done
Comment on attachment 283017 [details] Patch for landing Clearing flags on attachment: 283017 Committed r202910: <http://trac.webkit.org/changeset/202910>
All reviewed patches have been landed. Closing bug.