Bug 159504 - [JSC] Array.prototype[Symbol.unscopables] should have the "includes" property
Summary: [JSC] Array.prototype[Symbol.unscopables] should have the "includes" property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-06 22:19 PDT by Benjamin Poulain
Modified: 2016-07-07 16:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.09 KB, patch)
2016-07-06 22:20 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (9.10 KB, patch)
2016-07-06 22:52 PDT, Benjamin Poulain 		keith_miller: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-07-06 22:19:08 PDT 
[JSC] Array.prototype[unscopables] should have the "includes" property
Comment 1 Benjamin Poulain 2016-07-06 22:20:06 PDT 
Created attachment 282989 [details]
Patch
Comment 2 Benjamin Poulain 2016-07-06 22:52:25 PDT 
Created attachment 282990 [details]
Patch
Comment 3 Keith Miller 2016-07-07 15:49:31 PDT 
Comment on attachment 282990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282990&action=review

r=me with comment.

> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] Array.prototype[unscopables] should have the "includes" property

You might want to change this to Array.prototype[@@unscopables] or Array.prototype[Symbol.unscopables]. It's a little confusing as is.
Comment 4 Benjamin Poulain 2016-07-07 16:22:50 PDT 
Committed r202943: <http://trac.webkit.org/changeset/202943>