Bug 159500 – [JSC] Unify how we throw TypeError from C++

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

[JSC] Unify how we throw TypeError from C++

[Benjamin Poulain]

Created attachment 282980 [details]
Patch

[Saam Barati]

Comment on attachment 282980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282980&action=review

r=me with comments

> Source/JavaScriptCore/ChangeLog:8
> +        Throwing a TypeError is a uncommon case. We should minimize the impact

"a" => "an"

> Source/JavaScriptCore/ChangeLog:17
> +        On x86_64, this reduces the __TEXT__ segment by 29kb.

nice!

> Source/JavaScriptCore/runtime/Error.h:87
> +inline EncodedJSValue throwVMTypeError(ExecState* exec, ASCIILiteral errorMessage) { return JSValue::encode(throwTypeError(exec, errorMessage)); }

It's funny that "...VM..Error" just means that we return an EncodedJSValue. I wish we had a better name

> Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp:61
> +        return throwVMTypeError(exec, \

Style: This "\" should be aligned with the other "\"

[Benjamin Poulain]

Committed r202890: <http://trac.webkit.org/changeset/202890>