Bug 159487 - Web Inspector: REGRESSION: Hitting ⌘T in Web Inspector no longer opens in new tab in Safari
Summary: Web Inspector: REGRESSION: Hitting ⌘T in Web Inspector no longer opens in new...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-06 13:32 PDT by Timothy Hatcher
Modified: 2016-07-06 20:26 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.97 KB, patch)
2016-07-06 13:37 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (3.04 KB, patch)
2016-07-06 14:54 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-07-06 13:32:02 PDT
Ricky: "I’ve grown used to this over a number of years."

<rdar://problem/27188047>
Comment 1 Timothy Hatcher 2016-07-06 13:37:11 PDT
Created attachment 282938 [details]
Patch
Comment 2 Nikita Vasilyev 2016-07-06 13:42:01 PDT
Comment on attachment 282938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282938&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:272
> +    this._openNewTabKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, "T", this.showNewTabTab.bind(this));

Command-Shift-T reopens last closed tab in Safari 10.
Comment 3 Timothy Hatcher 2016-07-06 14:54:01 PDT
Created attachment 282953 [details]
Patch
Comment 4 Joseph Pecoraro 2016-07-06 20:04:43 PDT
Comment on attachment 282953 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2016-07-06 20:26:28 PDT
Comment on attachment 282953 [details]
Patch

Clearing flags on attachment: 282953

Committed r202891: <http://trac.webkit.org/changeset/202891>
Comment 6 WebKit Commit Bot 2016-07-06 20:26:33 PDT
All reviewed patches have been landed.  Closing bug.