Bug 159474 - Add support for Node.isConnected
Summary: Add support for Node.isConnected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#dom-node...
Keywords: InRadar, WebExposed
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2016-07-06 10:05 PDT by Chris Dumez
Modified: 2016-07-06 12:54 PDT (History)
7 users (show)

See Also:


Attachments
Patch (15.21 KB, patch)
2016-07-06 10:08 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (16.61 KB, patch)
2016-07-06 10:50 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (16.64 KB, patch)
2016-07-06 12:33 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-06 10:05:11 PDT
Add support for Node.isConnected as per:
https://dom.spec.whatwg.org/#dom-node-isconnected

Chrome already supports this.
Comment 1 Radar WebKit Bug Importer 2016-07-06 10:06:06 PDT
<rdar://problem/27197947>
Comment 2 Chris Dumez 2016-07-06 10:08:26 PDT
Created attachment 282906 [details]
Patch
Comment 3 Chris Dumez 2016-07-06 10:50:05 PDT
Created attachment 282909 [details]
Patch
Comment 4 Chris Dumez 2016-07-06 12:10:44 PDT
Comment on attachment 282909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282909&action=review

> Source/WebCore/dom/Node.idl:123
> +    [ImplementedAs=inDocument] readonly attribute boolean isConnected;

Ryosuke, should this be [EnabledAtRuntime=ShadowDOM] as well?
Comment 5 Ryosuke Niwa 2016-07-06 12:30:44 PDT
Comment on attachment 282909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282909&action=review

>> Source/WebCore/dom/Node.idl:123
>> +    [ImplementedAs=inDocument] readonly attribute boolean isConnected;
> 
> Ryosuke, should this be [EnabledAtRuntime=ShadowDOM] as well?

Probably.
Comment 6 Ryosuke Niwa 2016-07-06 12:31:20 PDT
Comment on attachment 282909 [details]
Patch

I guess cq- because of that one line change needed.
Comment 7 Chris Dumez 2016-07-06 12:33:18 PDT
Created attachment 282928 [details]
Patch
Comment 8 WebKit Commit Bot 2016-07-06 12:54:44 PDT
Comment on attachment 282928 [details]
Patch

Clearing flags on attachment: 282928

Committed r202870: <http://trac.webkit.org/changeset/202870>
Comment 9 WebKit Commit Bot 2016-07-06 12:54:49 PDT
All reviewed patches have been landed.  Closing bug.