WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
159474
Add support for Node.isConnected
https://bugs.webkit.org/show_bug.cgi?id=159474
Summary
Add support for Node.isConnected
Chris Dumez
Reported
2016-07-06 10:05:11 PDT
Add support for Node.isConnected as per:
https://dom.spec.whatwg.org/#dom-node-isconnected
Chrome already supports this.
Attachments
Patch
(15.21 KB, patch)
2016-07-06 10:08 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(16.61 KB, patch)
2016-07-06 10:50 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(16.64 KB, patch)
2016-07-06 12:33 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-07-06 10:06:06 PDT
<
rdar://problem/27197947
>
Chris Dumez
Comment 2
2016-07-06 10:08:26 PDT
Created
attachment 282906
[details]
Patch
Chris Dumez
Comment 3
2016-07-06 10:50:05 PDT
Created
attachment 282909
[details]
Patch
Chris Dumez
Comment 4
2016-07-06 12:10:44 PDT
Comment on
attachment 282909
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=282909&action=review
> Source/WebCore/dom/Node.idl:123 > + [ImplementedAs=inDocument] readonly attribute boolean isConnected;
Ryosuke, should this be [EnabledAtRuntime=ShadowDOM] as well?
Ryosuke Niwa
Comment 5
2016-07-06 12:30:44 PDT
Comment on
attachment 282909
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=282909&action=review
>> Source/WebCore/dom/Node.idl:123 >> + [ImplementedAs=inDocument] readonly attribute boolean isConnected; > > Ryosuke, should this be [EnabledAtRuntime=ShadowDOM] as well?
Probably.
Ryosuke Niwa
Comment 6
2016-07-06 12:31:20 PDT
Comment on
attachment 282909
[details]
Patch I guess cq- because of that one line change needed.
Chris Dumez
Comment 7
2016-07-06 12:33:18 PDT
Created
attachment 282928
[details]
Patch
WebKit Commit Bot
Comment 8
2016-07-06 12:54:44 PDT
Comment on
attachment 282928
[details]
Patch Clearing flags on attachment: 282928 Committed
r202870
: <
http://trac.webkit.org/changeset/202870
>
WebKit Commit Bot
Comment 9
2016-07-06 12:54:49 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug