Bug 159469 – [Coordinated Graphics] Remove toCoordinatedGraphicsLayer and use downcast instead

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Carlos Garcia Campos]

ssia

[Carlos Garcia Campos]

Created attachment 282901 [details]
Patch

We should also rename CoordinatedGraphicsLayer as GraphicsLayerCoordinated for consistency will all other GraphicsLayer implementations. Or is there any reason why this is named this way?

[Carlos Garcia Campos]

Created attachment 282992 [details]
Try to fix EFL build

[Michael Catanzaro]

Comment on attachment 282992 [details]
Try to fix EFL build

View in context: https://bugs.webkit.org/attachment.cgi?id=282992&action=review

> Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:66
> +        downcast<CoordinatedGraphicsLayer>(*static_cast<GraphicsLayer*>(node->layer())).setFixedToViewport(false);

Why do you need this static_cast?

[Carlos Garcia Campos]

(In reply to comment #3)
> Comment on attachment 282992 [details]
> Try to fix EFL build
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282992&action=review
> 
> > Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:66
> > +        downcast<CoordinatedGraphicsLayer>(*static_cast<GraphicsLayer*>(node->layer())).setFixedToViewport(false);
> 
> Why do you need this static_cast?

To disambiguate the * operator of ScrollingStateNode

[Carlos Garcia Campos]

Committed r203157: <http://trac.webkit.org/changeset/203157>