Bug 159469 - [Coordinated Graphics] Remove toCoordinatedGraphicsLayer and use downcast instead
Summary: [Coordinated Graphics] Remove toCoordinatedGraphicsLayer and use downcast ins...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-06 09:16 PDT by Carlos Garcia Campos
Modified: 2016-07-13 04:01 PDT (History)
2 users (show)

See Also:

Attachments
Patch (15.97 KB, patch)
2016-07-06 09:18 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Try to fix EFL build (16.80 KB, patch)
2016-07-06 23:10 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-07-06 09:16:46 PDT 
ssia
Comment 1 Carlos Garcia Campos 2016-07-06 09:18:58 PDT 
Created attachment 282901 [details]
Patch

We should also rename CoordinatedGraphicsLayer as GraphicsLayerCoordinated for consistency will all other GraphicsLayer implementations. Or is there any reason why this is named this way?
Comment 2 Carlos Garcia Campos 2016-07-06 23:10:32 PDT 
Created attachment 282992 [details]
Try to fix EFL build
Comment 3 Michael Catanzaro 2016-07-10 13:48:51 PDT 
Comment on attachment 282992 [details]
Try to fix EFL build

View in context: https://bugs.webkit.org/attachment.cgi?id=282992&action=review

> Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:66
> +        downcast<CoordinatedGraphicsLayer>(*static_cast<GraphicsLayer*>(node->layer())).setFixedToViewport(false);

Why do you need this static_cast?
Comment 4 Carlos Garcia Campos 2016-07-13 03:59:47 PDT 
(In reply to comment #3)
> Comment on attachment 282992 [details]
> Try to fix EFL build
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282992&action=review
> 
> > Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:66
> > +        downcast<CoordinatedGraphicsLayer>(*static_cast<GraphicsLayer*>(node->layer())).setFixedToViewport(false);
> 
> Why do you need this static_cast?

To disambiguate the * operator of ScrollingStateNode
Comment 5 Carlos Garcia Campos 2016-07-13 04:01:39 PDT 
Committed r203157: <http://trac.webkit.org/changeset/203157>