Bug 159458 – [GStreamer] duration query improvements

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Philippe Normand]

Currently the player caches the result of the duration query but this is overkill because it's cached by playbin already. The only time where the player needs to cache the duration is when EOS was reached because in that situation the query would fail.

[Philippe Normand]

Created attachment 282866 [details]
patch

[Xabier Rodríguez Calvar]

Comment on attachment 282866 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282866&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:521
> +    m_durationAtEOS = 0;

Why do you need this?

[Philippe Normand]

Committed r202857: <http://trac.webkit.org/changeset/202857>

[Philippe Normand]

Comment on attachment 282866 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282866&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:521
>> +    m_durationAtEOS = 0;
> 
> Why do you need this?

For no good reason it seems :)

[Xabier Rodríguez Calvar]

Comment on attachment 282866 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282866&action=review

>>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:521
>>> +    m_durationAtEOS = 0;
>> 
>> Why do you need this?
> 
> For no good reason it seems :)

Well, I guess it is correct to assume that if you are seeking and the end is not reached as it is set in like 520, considering the new paradigm of not caching the duration until the playback ends, we should not have a valid value here.